PMD Results

The following document contains the results of PMD.

Summary

Files Errors
78 123

Files

Files Violations
dk/netarkivet/archive/arcrepository/bitpreservation/DatabaseBasedActiveBitPreservation.java 1
dk/netarkivet/archive/arcrepositoryadmin/ReplicaCacheHelpers.java 1
dk/netarkivet/archive/checksum/distribute/ChecksumFileServer.java 1
dk/netarkivet/archive/indexserver/CDXOriginCrawlLogIterator.java 1
dk/netarkivet/archive/indexserver/distribute/IndexRequestServer.java 3
dk/netarkivet/archive/indexserver/distribute/TestIndexRequestServer.java 2
dk/netarkivet/archive/tools/CreateIndex.java 1
dk/netarkivet/archive/webinterface/BatchGUI.java 1
dk/netarkivet/archive/webinterface/BitpreserveFileState.java 1
dk/netarkivet/common/distribute/ChannelID.java 1
dk/netarkivet/common/distribute/ExtendedFTPRemoteFile.java 4
dk/netarkivet/common/distribute/FileRemoteFile.java 2
dk/netarkivet/common/distribute/HTTPRemoteFile.java 1
dk/netarkivet/common/distribute/HTTPRemoteFileRegistry.java 1
dk/netarkivet/common/distribute/HTTPSRemoteFile.java 2
dk/netarkivet/common/distribute/JMSConnection.java 1
dk/netarkivet/common/distribute/RemoteFile.java 2
dk/netarkivet/common/distribute/arcrepository/ViewerArcRepositoryClient.java 1
dk/netarkivet/common/distribute/indexserver/TrivialJobIndexCache.java 1
dk/netarkivet/common/lifecycle/PeriodicTaskExecutor.java 5
dk/netarkivet/common/utils/ApplicationUtils.java 1
dk/netarkivet/common/utils/CleanupHook.java 1
dk/netarkivet/common/utils/InputStreamUtils.java 3
dk/netarkivet/common/utils/ShutdownHook.java 1
dk/netarkivet/common/utils/SimpleXml.java 1
dk/netarkivet/common/utils/StringTree.java 2
dk/netarkivet/common/utils/SystemUtils.java 1
dk/netarkivet/common/utils/batch/FileBatchJob.java 1
dk/netarkivet/common/utils/batch/LoadableFileBatchJob.java 1
dk/netarkivet/common/utils/batch/LoadableJarBatchJob.java 1
dk/netarkivet/common/utils/cdx/GetCDXRecordsBatchJob.java 1
dk/netarkivet/deploy/LinuxMachine.java 1
dk/netarkivet/harvester/HarvesterSettings.java 7
dk/netarkivet/harvester/datamodel/DBSpecifics.java 1
dk/netarkivet/harvester/datamodel/DerbySpecifics.java 1
dk/netarkivet/harvester/datamodel/DomainDAO.java 2
dk/netarkivet/harvester/datamodel/HarvestDefinitionDAO.java 1
dk/netarkivet/harvester/datamodel/Job.java 2
dk/netarkivet/harvester/datamodel/JobDAO.java 2
dk/netarkivet/harvester/datamodel/MySQLSpecifics.java 1
dk/netarkivet/harvester/datamodel/PartialHarvest.java 4
dk/netarkivet/harvester/datamodel/PostgreSQLSpecifics.java 1
dk/netarkivet/harvester/datamodel/RunningJobsInfoDAO.java 1
dk/netarkivet/harvester/datamodel/RunningJobsInfoDBDAO.java 1
dk/netarkivet/harvester/datamodel/ScheduleDAO.java 4
dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldDBDAO.java 1
dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldOptions.java 1
dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldTypeDBDAO.java 1
dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldValueDBDAO.java 1
dk/netarkivet/harvester/distribute/HarvesterMessage.java 1
dk/netarkivet/harvester/harvesting/ArcFilesReportGenerator.java 2
dk/netarkivet/harvester/harvesting/controller/AbstractJMXHeritrixController.java 1
dk/netarkivet/harvester/harvesting/controller/BnfHeritrixController.java 2
dk/netarkivet/harvester/harvesting/controller/BnfHeritrixLauncher.java 1
dk/netarkivet/harvester/harvesting/controller/JMXHeritrixController.java 3
dk/netarkivet/harvester/harvesting/distribute/CrawlProgressMessage.java 1
dk/netarkivet/harvester/harvesting/distribute/HarvesterReadyMessage.java 1
dk/netarkivet/harvester/harvesting/distribute/JobEndedMessage.java 1
dk/netarkivet/harvester/harvesting/frontier/FrontierReportAnalyzer.java 1
dk/netarkivet/harvester/harvesting/frontier/FullFrontierReport.java 4
dk/netarkivet/harvester/harvesting/frontier/RetiredQueuesFilter.java 1
dk/netarkivet/harvester/harvesting/monitor/StartedJobHistoryChartGen.java 1
dk/netarkivet/harvester/harvesting/report/BnfHarvestReport.java 1
dk/netarkivet/harvester/webinterface/DomainDefinition.java 1
dk/netarkivet/harvester/webinterface/HarvestStatusQuery.java 1
dk/netarkivet/harvester/webinterface/ScheduleDefinition.java 1
dk/netarkivet/harvester/webinterface/SelectiveHarvestUtil.java 1
dk/netarkivet/monitor/distribute/JMSMonitorRegistryClient.java 1
dk/netarkivet/monitor/distribute/MonitorMessage.java 1
dk/netarkivet/monitor/jmx/JMXProxyConnection.java 2
dk/netarkivet/monitor/logging/CachingLogHandler.java 2
dk/netarkivet/monitor/logging/CachingLogRecord.java 1
dk/netarkivet/viewerproxy/ARCArchiveAccess.java 2
dk/netarkivet/viewerproxy/URIObserver.java 2
dk/netarkivet/viewerproxy/UnknownCommandResolver.java 1
dk/netarkivet/viewerproxy/WebProxy.java 1
dk/netarkivet/wayback/DeduplicateToCDXApplication.java 1
dk/netarkivet/wayback/batch/copycode/NetarchiveSuiteUURIFactory.java 4

dk/netarkivet/archive/arcrepository/bitpreservation/DatabaseBasedActiveBitPreservation.java

Violation Line
Avoid unused imports such as 'java.io.IOException' - details... 29

dk/netarkivet/archive/arcrepositoryadmin/ReplicaCacheHelpers.java

Violation Line
Avoid unused imports such as 'java.util.Collection' - details... 35

dk/netarkivet/archive/checksum/distribute/ChecksumFileServer.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.distribute.RemoteFile' - details... 40

dk/netarkivet/archive/indexserver/CDXOriginCrawlLogIterator.java

Violation Line
These nested if statements could be combined - details... 131

dk/netarkivet/archive/indexserver/distribute/IndexRequestServer.java

Violation Line
These nested if statements could be combined - details... 246
Avoid unused local variables such as 'theFoundIDs'. - details... 348
These nested if statements could be combined - details... 565

dk/netarkivet/archive/indexserver/distribute/TestIndexRequestServer.java

Violation Line
These nested if statements could be combined - details... 302
These nested if statements could be combined - details... 554

dk/netarkivet/archive/tools/CreateIndex.java

Violation Line
Avoid unused local variables such as 'index'. - details... 122

dk/netarkivet/archive/webinterface/BatchGUI.java

Violation Line
This usage of the Collection.toArray() method will throw a ClassCastException. - details... 247

dk/netarkivet/archive/webinterface/BitpreserveFileState.java

Violation Line
Avoid unused private methods such as 'checkArgs(PageContext,String,String,String)'. - details... 246

dk/netarkivet/common/distribute/ChannelID.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.UnknownID' - details... 33

dk/netarkivet/common/distribute/ExtendedFTPRemoteFile.java

Violation Line
Avoid unused imports such as 'java.security.DigestInputStream' - details... 9
Avoid unused imports such as 'dk.netarkivet.common.CommonSettings' - details... 13
Avoid unused imports such as 'dk.netarkivet.common.utils.MD5' - details... 17
Avoid unused imports such as 'dk.netarkivet.common.utils.StreamUtils' - details... 19

dk/netarkivet/common/distribute/FileRemoteFile.java

Violation Line
No need to import a type that lives in the same package - details... 37
Avoid unused private fields such as 'log'. - details... 52

dk/netarkivet/common/distribute/HTTPRemoteFile.java

Violation Line
These nested if statements could be combined - details... 175

dk/netarkivet/common/distribute/HTTPRemoteFileRegistry.java

Violation Line
Avoid empty catch blocks - details... 229

dk/netarkivet/common/distribute/HTTPSRemoteFile.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 29
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 30

dk/netarkivet/common/distribute/JMSConnection.java

Violation Line
Avoid empty catch blocks - details... 330

dk/netarkivet/common/distribute/RemoteFile.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 32
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 33

dk/netarkivet/common/distribute/arcrepository/ViewerArcRepositoryClient.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 30

dk/netarkivet/common/distribute/indexserver/TrivialJobIndexCache.java

Violation Line
Avoid unused private fields such as 'log'. - details... 47

dk/netarkivet/common/lifecycle/PeriodicTaskExecutor.java

Violation Line
Avoid unused private fields such as 'taskId'. - details... 64
Avoid unused private fields such as 'task'. - details... 69
Avoid unused private fields such as 'secondsBeforeFirstExec'. - details... 75
Avoid unused private fields such as 'secondsBetweenExec'. - details... 80
Avoid unused private fields such as 'future'. - details... 85

dk/netarkivet/common/utils/ApplicationUtils.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.PermissionDenied' - details... 37

dk/netarkivet/common/utils/CleanupHook.java

Violation Line
Avoid empty catch blocks - details... 65

dk/netarkivet/common/utils/InputStreamUtils.java

Violation Line
These nested if statements could be combined - details... 51
These nested if statements could be combined - details... 54
Avoid unused local variables such as 'counter'. - details... 75

dk/netarkivet/common/utils/ShutdownHook.java

Violation Line
Avoid empty catch blocks - details... 65

dk/netarkivet/common/utils/SimpleXml.java

Violation Line
Avoid unused local variables such as 'newNode'. - details... 144

dk/netarkivet/common/utils/StringTree.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 31
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IllegalState' - details... 32

dk/netarkivet/common/utils/SystemUtils.java

Violation Line
Avoid empty catch blocks - details... 76

dk/netarkivet/common/utils/batch/FileBatchJob.java

Violation Line
Avoid unused private fields such as 'MAX_EXCEPTIONS'. - details... 335

dk/netarkivet/common/utils/batch/LoadableFileBatchJob.java

Violation Line
This usage of the Collection.toArray() method will throw a ClassCastException. - details... 144

dk/netarkivet/common/utils/batch/LoadableJarBatchJob.java

Violation Line
This usage of the Collection.toArray() method will throw a ClassCastException. - details... 118

dk/netarkivet/common/utils/cdx/GetCDXRecordsBatchJob.java

Violation Line
Avoid empty finally blocks - details... 79

dk/netarkivet/deploy/LinuxMachine.java

Violation Line
An empty statement (semicolon) not part of a loop - details... 1532

dk/netarkivet/harvester/HarvesterSettings.java

Violation Line
Avoid unused imports such as 'java.util.regex.Pattern' - details... 27
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.HarvestDocumentation' - details... 30
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController' - details... 31
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage' - details... 32
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.frontier.TopTotalEnqueuesFilter' - details... 33
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.report.HarvestReport' - details... 34
Avoid unused imports such as 'dk.netarkivet.harvester.scheduler.JobDispatcher' - details... 35

dk/netarkivet/harvester/datamodel/DBSpecifics.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 36

dk/netarkivet/harvester/datamodel/DerbySpecifics.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 36

dk/netarkivet/harvester/datamodel/DomainDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 31
Avoid unused imports such as 'dk.netarkivet.common.exceptions.UnknownID' - details... 32

dk/netarkivet/harvester/datamodel/HarvestDefinitionDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 36

dk/netarkivet/harvester/datamodel/Job.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.PermissionDenied' - details... 62
Avoid unused imports such as 'dk.netarkivet.common.exceptions.UnknownID' - details... 63

dk/netarkivet/harvester/datamodel/JobDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IllegalState' - details... 32
Avoid unused imports such as 'dk.netarkivet.common.exceptions.PermissionDenied' - details... 33

dk/netarkivet/harvester/datamodel/MySQLSpecifics.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 35

dk/netarkivet/harvester/datamodel/PartialHarvest.java

Violation Line
Avoid unused imports such as 'javax.servlet.jsp.PageContext' - details... 27
Avoid unused imports such as 'dk.netarkivet.common.utils.I18n' - details... 52
Avoid unused imports such as 'dk.netarkivet.harvester.HarvesterSettings' - details... 53
Avoid unused imports such as 'dk.netarkivet.harvester.webinterface.EventHarvestUtil' - details... 54

dk/netarkivet/harvester/datamodel/PostgreSQLSpecifics.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 36

dk/netarkivet/harvester/datamodel/RunningJobsInfoDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.frontier.FrontierReportFilter' - details... 31

dk/netarkivet/harvester/datamodel/RunningJobsInfoDBDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.frontier.FrontierReportFilter' - details... 55

dk/netarkivet/harvester/datamodel/ScheduleDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 29
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 30
Avoid unused imports such as 'dk.netarkivet.common.exceptions.PermissionDenied' - details... 31
Avoid unused imports such as 'dk.netarkivet.common.exceptions.UnknownID' - details... 32

dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldDBDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.datamodel.DBSpecifics' - details... 43

dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldOptions.java

Violation Line
These nested if statements could be combined - details... 135

dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldTypeDBDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.datamodel.DBSpecifics' - details... 43

dk/netarkivet/harvester/datamodel/extendedfield/ExtendedFieldValueDBDAO.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.datamodel.DBSpecifics' - details... 40

dk/netarkivet/harvester/distribute/HarvesterMessage.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 32

dk/netarkivet/harvester/harvesting/ArcFilesReportGenerator.java

Violation Line
Avoid empty catch blocks - details... 234
Avoid empty catch blocks - details... 254

dk/netarkivet/harvester/harvesting/controller/AbstractJMXHeritrixController.java

Violation Line
Avoid empty catch blocks - details... 430

dk/netarkivet/harvester/harvesting/controller/BnfHeritrixController.java

Violation Line
Avoid unused method parameters such as 'crawlDir'. - details... 625
Avoid unused private methods such as 'executeMBeanOperation(CrawlServiceOperation,String)'. - details... 711

dk/netarkivet/harvester/harvesting/controller/BnfHeritrixLauncher.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor' - details... 39

dk/netarkivet/harvester/harvesting/controller/JMXHeritrixController.java

Violation Line
Avoid unused private methods such as 'executeHeritrixCommand(String,String)'. - details... 490
Avoid unused private methods such as 'executeCrawlJobCommand(String,String)'. - details... 504
Avoid unused private methods such as 'getHeritrixAttribute(String)'. - details... 515

dk/netarkivet/harvester/harvesting/distribute/CrawlProgressMessage.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.HeritrixLauncher' - details... 34

dk/netarkivet/harvester/harvesting/distribute/HarvesterReadyMessage.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.scheduler.JobDispatcher' - details... 33

dk/netarkivet/harvester/harvesting/distribute/JobEndedMessage.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.scheduler.HarvestSchedulerMonitorServer' - details... 35

dk/netarkivet/harvester/harvesting/frontier/FrontierReportAnalyzer.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor' - details... 41

dk/netarkivet/harvester/harvesting/frontier/FullFrontierReport.java

Violation Line
Avoid unused private fields such as 'primaryKey'. - details... 116
Avoid unused private fields such as 'domainNameKey'. - details... 119
Avoid unused private fields such as 'totalSpendKey'. - details... 122
Avoid unused private fields such as 'currentSizeKey'. - details... 125

dk/netarkivet/harvester/harvesting/frontier/RetiredQueuesFilter.java

Violation Line
Avoid unused imports such as 'org.archive.crawler.frontier.WorkQueue' - details... 27

dk/netarkivet/harvester/harvesting/monitor/StartedJobHistoryChartGen.java

Violation Line
These nested if statements could be combined - details... 348

dk/netarkivet/harvester/harvesting/report/BnfHarvestReport.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.harvester.HarvesterSettings' - details... 39

dk/netarkivet/harvester/webinterface/DomainDefinition.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 37

dk/netarkivet/harvester/webinterface/HarvestStatusQuery.java

Violation Line
These nested if statements could be combined - details... 276

dk/netarkivet/harvester/webinterface/ScheduleDefinition.java

Violation Line
Avoid unused method parameters such as 'i18n'. - details... 296

dk/netarkivet/harvester/webinterface/SelectiveHarvestUtil.java

Violation Line
These nested if statements could be combined - details... 322

dk/netarkivet/monitor/distribute/JMSMonitorRegistryClient.java

Violation Line
Avoid empty catch blocks - details... 160

dk/netarkivet/monitor/distribute/MonitorMessage.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 32

dk/netarkivet/monitor/jmx/JMXProxyConnection.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 30
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 31

dk/netarkivet/monitor/logging/CachingLogHandler.java

Violation Line
Avoid empty catch blocks - details... 107
Avoid empty catch blocks - details... 140

dk/netarkivet/monitor/logging/CachingLogRecord.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.IOFailure' - details... 32

dk/netarkivet/viewerproxy/ARCArchiveAccess.java

Violation Line
These nested if statements could be combined - details... 286
These nested if statements could be combined - details... 289

dk/netarkivet/viewerproxy/URIObserver.java

Violation Line
Avoid unused private fields such as 'uri'. - details... 49
Avoid unused private fields such as 'responseCode'. - details... 51

dk/netarkivet/viewerproxy/UnknownCommandResolver.java

Violation Line
Avoid unused imports such as 'dk.netarkivet.common.exceptions.ArgumentNotValid' - details... 31

dk/netarkivet/viewerproxy/WebProxy.java

Violation Line
Avoid unused imports such as 'org.mortbay.jetty.Handler' - details... 37

dk/netarkivet/wayback/DeduplicateToCDXApplication.java

Violation Line
Avoid unused imports such as 'java.io.FileNotFoundException' - details... 29

dk/netarkivet/wayback/batch/copycode/NetarchiveSuiteUURIFactory.java

Violation Line
Avoid unused private fields such as 'SCHEMES_KEY'. - details... 223
These nested if statements could be combined - details... 438
Avoid empty if statements - details... 644
Avoid empty catch blocks - details... 780