FindBugs Results

The following document contains the results of FindBugs.

Summary

Files Errors
244 677

Files

Files Violations
dk.netarkivet.common.utils.StreamUtils 1
dk.netarkivet.common.utils.SimpleXml 3
dk.netarkivet.common.utils.FileUtils$1 1
dk.netarkivet.common.utils.FileUtils$3 1
dk.netarkivet.common.utils.FileUtils$4 1
dk.netarkivet.common.utils.FileUtils 5
dk.netarkivet.deploy.CreateTestInstance 1
dk.netarkivet.deploy.DeployConfiguration 2
dk.netarkivet.deploy.DeployApplication 8
dk.netarkivet.common.distribute.arcrepository.ReplicaType 1
dk.netarkivet.common.distribute.ChannelID 3
dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory 4
dk.netarkivet.common.distribute.RemoteFileSettings 1
dk.netarkivet.common.utils.InputStreamUtils 1
dk.netarkivet.common.utils.arc.ARCUtils 1
dk.netarkivet.common.distribute.arcrepository.BitarchiveRecord 1
dk.netarkivet.common.utils.batch.FileBatchJob$ExceptionOccurrence 1
dk.netarkivet.common.utils.arc.ARCBatchJob 1
dk.netarkivet.viewerproxy.LocalCDXCache$CDXCacheBatchJob 1
dk.netarkivet.common.utils.SparseBitSet 1
dk.netarkivet.common.utils.SparseRangeFilter 1
dk.netarkivet.common.utils.arc.ARCKey 1
dk.netarkivet.viewerproxy.ARCArchiveAccess 1
dk.netarkivet.viewerproxy.GetDataResolver$GetFileBatchJob 2
dk.netarkivet.viewerproxy.ViewerProxy 1
dk.netarkivet.common.utils.ApplicationUtils 3
dk.netarkivet.archive.indexserver.RawMetadataCache$GetMetadataARCBatchJob 1
dk.netarkivet.archive.indexserver.CDXOriginCrawlLogIterator 1
dk.netarkivet.archive.indexserver.CrawlLogIndexCache 1
dk.netarkivet.archive.indexserver.IndexServer 1
dk.netarkivet.archive.bitarchive.BitarchiveMonitor 1
dk.netarkivet.archive.bitarchive.BitarchiveAdmin 1
dk.netarkivet.common.utils.batch.BatchLocalFiles 2
dk.netarkivet.archive.bitarchive.Bitarchive 1
dk.netarkivet.archive.bitarchive.distribute.BatchMessage 1
dk.netarkivet.archive.bitarchive.distribute.BatchTerminationMessage 1
dk.netarkivet.archive.bitarchive.distribute.BatchEndedMessage 1
dk.netarkivet.common.distribute.JMSConnection 2
dk.netarkivet.common.distribute.NullRemoteFile 1
dk.netarkivet.archive.bitarchive.distribute.GetFileMessage 1
dk.netarkivet.archive.bitarchive.distribute.GetMessage 1
dk.netarkivet.archive.bitarchive.distribute.HeartBeatMessage 1
dk.netarkivet.archive.bitarchive.distribute.RemoveAndGetFileMessage 1
dk.netarkivet.archive.bitarchive.distribute.UploadMessage 1
dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer 4
dk.netarkivet.archive.bitarchive.distribute.BatchReplyMessage 1
dk.netarkivet.archive.checksum.distribute.CorrectMessage 1
dk.netarkivet.archive.checksum.distribute.GetAllChecksumsMessage 1
dk.netarkivet.archive.checksum.distribute.GetAllFilenamesMessage 1
dk.netarkivet.archive.checksum.distribute.GetChecksumMessage 1
dk.netarkivet.common.utils.batch.ChecksumJob 1
dk.netarkivet.common.utils.batch.FileListJob 1
dk.netarkivet.archive.bitarchive.distribute.BitarchiveMonitorServer 3
dk.netarkivet.archive.arcrepository.distribute.StoreMessage 1
dk.netarkivet.archive.arcrepositoryadmin.ArchiveStoreState 2
dk.netarkivet.archive.arcrepositoryadmin.AdminData 9
dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection 3
dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers 4
dk.netarkivet.archive.arcrepositoryadmin.DerbyEmbeddedSpecifics 1
dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase 9
dk.netarkivet.archive.arcrepositoryadmin.DatabaseAdmin 1
dk.netarkivet.common.tools.ToolRunnerBase 1
dk.netarkivet.archive.tools.CreateIndex 3
dk.netarkivet.archive.tools.ReestablishAdminDatabase$ReestablishAdminDatabaseTool 1
dk.netarkivet.archive.tools.GetFile$GetFileTool 1
dk.netarkivet.archive.tools.RunBatch$RunBatchTool$BatchParameters 2
dk.netarkivet.common.utils.batch.ByteClassLoader 1
dk.netarkivet.common.utils.batch.LoadableFileBatchJob 2
dk.netarkivet.common.utils.batch.ByteJarLoader 2
dk.netarkivet.common.utils.batch.LoadableJarBatchJob 3
dk.netarkivet.archive.tools.RunBatch$RunBatchTool 2
dk.netarkivet.common.webinterface.HTMLUtils 1
dk.netarkivet.common.webinterface.SiteSection 1
dk.netarkivet.archive.webinterface.BatchExecuter 3
dk.netarkivet.archive.webinterface.BatchGUI 1
dk.netarkivet.archive.arcrepository.bitpreservation.AdminDataMessage 1
dk.netarkivet.archive.arcrepository.ArcRepository 2
dk.netarkivet.archive.checksum.FileChecksumArchive 11
dk.netarkivet.archive.checksum.distribute.ChecksumFileServer 2
dk.netarkivet.wayback.aggregator.IndexAggregator 1
dk.netarkivet.wayback.batch.ExtractDeduplicateCDXBatchJob 2
dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob 4
dk.netarkivet.wayback.indexer.ArchiveFile 4
dk.netarkivet.wayback.indexer.IndexerQueue 1
dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp 2
dk.netarkivet.common.utils.FixedUURI 1
dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob 2
dk.netarkivet.common.utils.cdx.ExtractCDXJob 2
dk.netarkivet.monitor.jmx.RmiProxyConnectionFactory$MBeanServerProxyConnection 1
dk.netarkivet.common.distribute.monitorregistry.HostEntry 3
dk.netarkivet.common.management.SingleMBeanObject 1
dk.netarkivet.monitor.jmx.HostForwarding 2
dk.netarkivet.monitor.distribute.MonitorMessage 1
dk.netarkivet.monitor.registry.distribute.RegisterHostMessage 1
dk.netarkivet.monitor.logging.CachingLogHandler 2
dk.netarkivet.monitor.tools.JMXProxy$1 3
dk.netarkivet.monitor.webinterface.JMXStatusEntry 2
dk.netarkivet.monitor.webinterface.JMXSummaryUtils 3
dk.netarkivet.harvester.datamodel.DerbySpecifics 1
dk.netarkivet.harvester.datamodel.HarvestDBConnection 2
dk.netarkivet.harvester.datamodel.HarvestInfo 2
dk.netarkivet.harvester.datamodel.GlobalCrawlerTrapListDBDAO 1
dk.netarkivet.harvester.datamodel.SeedList 1
dk.netarkivet.harvester.datamodel.Job 9
dk.netarkivet.harvester.datamodel.HarvestDefinition$CompareConfigsDesc 1
dk.netarkivet.harvester.datamodel.JobDBDAO$HarvestStatusQueryBuilder 2
dk.netarkivet.harvester.datamodel.JobStatusInfo 3
dk.netarkivet.harvester.datamodel.JobDBDAO 5
dk.netarkivet.harvester.datamodel.RepeatingSchedule 1
dk.netarkivet.harvester.datamodel.TimedSchedule 2
dk.netarkivet.harvester.datamodel.Schedule 2
dk.netarkivet.harvester.datamodel.ScheduleDBDAO 2
dk.netarkivet.harvester.datamodel.PartialHarvest 2
dk.netarkivet.harvester.harvesting.HeritrixLauncher 2
dk.netarkivet.harvester.datamodel.HarvestDefinition 2
dk.netarkivet.harvester.datamodel.DomainHarvestInfo 2
dk.netarkivet.harvester.datamodel.DomainOwnerInfo 4
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldOptions 1
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedField 1
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDefaultValue 2
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldValue 1
dk.netarkivet.harvester.datamodel.DomainDBDAO 10
dk.netarkivet.harvester.datamodel.Domain 1
dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$SparseDomainConfigurationComparator 1
dk.netarkivet.harvester.datamodel.HarvestRunInfo 4
dk.netarkivet.harvester.datamodel.SparsePartialHarvest 3
dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO 1
dk.netarkivet.harvester.distribute.HarvesterMessage 1
dk.netarkivet.harvester.harvesting.distribute.PersistentJobData$HarvestDefinitionInfo 1
dk.netarkivet.harvester.harvesting.distribute.PersistentJobData 2
dk.netarkivet.harvester.harvesting.distribute.DoOneCrawlMessage 2
dk.netarkivet.harvester.harvesting.distribute.MetadataEntry 3
dk.netarkivet.harvester.scheduler.JobDispatcher 1
dk.netarkivet.common.lifecycle.PeriodicTaskExecutor 2
dk.netarkivet.harvester.scheduler.HarvestJobGenerator$JobGeneratorTask$1 1
dk.netarkivet.harvester.distribute.IndexReadyMessage 1
dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceInfo 2
dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceJobInfo 2
dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO$FR_COLUMN 1
dk.netarkivet.harvester.harvesting.frontier.FrontierReportLineNaturalOrder 1
dk.netarkivet.harvester.harvesting.frontier.FrontierReportLine 1
dk.netarkivet.harvester.harvesting.frontier.InMemoryFrontierReport 2
dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo 4
dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO 8
dk.netarkivet.harvester.harvesting.distribute.FrontierReportMessage 1
dk.netarkivet.harvester.harvesting.distribute.JobEndedMessage 2
dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLineKey 1
dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLine 2
dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport 11
dk.netarkivet.harvester.harvesting.frontier.ExhaustedQueuesFilter 1
dk.netarkivet.harvester.harvesting.frontier.RetiredQueuesFilter 1
dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor 2
dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage 2
dk.netarkivet.harvester.harvesting.distribute.CrawlStatusMessage 3
dk.netarkivet.harvester.scheduler.HarvestSchedulerMonitorServer 1
dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage 2
dk.netarkivet.common.utils.cdx.CDXUtils 1
dk.netarkivet.harvester.harvesting.ArcFilesReportGenerator 1
dk.netarkivet.harvester.harvesting.MetadataFile 1
dk.netarkivet.harvester.harvesting.HarvestDocumentation 1
dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$CrawlStatus 2
dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$HarvesterThread 1
dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer 2
dk.netarkivet.harvester.harvesting.OnNSDomainsDecideRule 2
dk.netarkivet.harvester.harvesting.ContentSizeAnnotationPostProcessor 1
dk.netarkivet.harvester.datamodel.MySQLSpecifics 1
dk.netarkivet.harvester.tools.HarvestTemplateApplication 1
dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport$FIELD 3
dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport 1
dk.netarkivet.harvester.webinterface.HarvestStatusRunningTablesSort 2
dk.netarkivet.harvester.webinterface.SnapshotHarvestDefinition 1
dk.netarkivet.common.utils.FilebasedFreeSpaceProvider 1
dk.netarkivet.common.utils.ReadOnlyByteArray 1
dk.netarkivet.common.distribute.AbstractRemoteFile 1
dk.netarkivet.common.distribute.FTPRemoteFile 5
dk.netarkivet.common.distribute.ExtendedFTPRemoteFile 4
dk.netarkivet.common.distribute.HTTPRemoteFile 3
dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$HTTPRemoteFileRegistryHandler 1
dk.netarkivet.common.distribute.HTTPRemoteFileRegistry 4
dk.netarkivet.common.distribute.HTTPSRemoteFile 4
dk.netarkivet.common.distribute.FileRemoteFile 2
dk.netarkivet.common.distribute.JMSConnectionSunMQ 4
dk.netarkivet.common.tools.ExtractCDX 1
dk.netarkivet.common.tools.ReformatTranslationFile 1
dk.netarkivet.common.webinterface.GUIWebServer 1
dk.netarkivet.archive.indexserver.distribute.IndexRequestMessage 1
dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer 6
dk.netarkivet.archive.indexserver.distribute.IndexRequestServer 5
dk.netarkivet.archive.arcrepository.distribute.JMSArcRepositoryClient 1
dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation 2
dk.netarkivet.archive.arcrepository.bitpreservation.DatabasePreservationState 1
dk.netarkivet.archive.arcrepository.bitpreservation.DatabaseBasedActiveBitPreservation 1
dk.netarkivet.harvester.harvesting.distribute.DomainStats 1
dk.netarkivet.harvester.harvesting.report.AbstractHarvestReport 3
dk.netarkivet.harvester.harvesting.report.LegacyHarvestReport 1
dk.netarkivet.harvester.harvesting.report.BnfHarvestReport 1
dk.netarkivet.harvester.harvesting.extractor.ExtractorOAI 4
dk.netarkivet.harvester.harvesting.controller.JMXHeritrixController 1
dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController 4
dk.netarkivet.harvester.harvesting.controller.BnfHeritrixLauncher 1
dk.netarkivet.harvester.harvesting.controller.DefaultHeritrixLauncher 2
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypes 2
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldType 1
dk.netarkivet.common.utils.batch.FileRemover 1
dk.netarkivet.common.utils.cdx.GetCDXRecordsBatchJob 1
dk.netarkivet.common.utils.cdx.BinSearch$PrefixIterable$1 1
dk.netarkivet.common.utils.cdx.ARCFilenameCDXRecordFilter 1
dk.netarkivet.harvester.datamodel.Password 2
dk.netarkivet.monitor.jmx.HostForwarding$NoHostInvocationHandler 1
dk.netarkivet.viewerproxy.DelegatingController 1
dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$FileInfo 1
dk.netarkivet.common.distribute.arcrepository.LocalArcRepositoryClient$1 1
dk.netarkivet.common.distribute.indexserver.TrivialJobIndexCache 1
dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$1 1
dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$ReportIterator 1
dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp$1 1
dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob$1 1
dk.netarkivet.wayback.NetarchiveResourceStore$1 1
dk.netarkivet.wayback.aggregator.AggregationWorker$2 1
dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$1 1
dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$2 1
dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$3 1
dk.netarkivet.deploy.ScriptConstants 2
dk.netarkivet.common.CommonSettings 70
dk.netarkivet.archive.ArchiveSettings 44
dk.netarkivet.common.utils.EMailNotifications 2
dk.netarkivet.harvester.HarvesterSettings 57
dk.netarkivet.monitor.MonitorSettings 7
dk.netarkivet.viewerproxy.ViewerProxySettings 3
dk.netarkivet.deploy.Constants 1
dk.netarkivet.wayback.WaybackSettings 32
dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUrlOperations 1
dk.netarkivet.common.management.MBeanConnectorCreator 1
dk.netarkivet.archive.checksum.distribute.ChecksumClient 1
dk.netarkivet.harvester.datamodel.JobStatus 8
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDAO 1
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldValueDAO 1
dk.netarkivet.harvester.scheduler.HarvestJobGenerator 1
dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypeDAO 1
dk.netarkivet.common.utils.cdx.CDXRecord 2
dk.netarkivet.harvester.datamodel.DomainConfiguration 2
dk.netarkivet.common.distribute.arcrepository.BatchStatus 1
dk.netarkivet.common.distribute.arcrepository.Replica 1
dk.netarkivet.harvester.webinterface.HarvestStatusQuery 1

dk.netarkivet.common.utils.StreamUtils

Violation Line Priority
XFB: Method dk.netarkivet.common.utils.StreamUtils.writeXmlToStream(Document, OutputStream) directly allocates a specific implementation of xml interfaces 159 Low

dk.netarkivet.common.utils.SimpleXml

Violation Line Priority
ITA: Method dk.netarkivet.common.utils.SimpleXml.add(String, String[]) uses Collection.toArray() with zero-length array argument 147 Low
DLS: Dead store to newNode in dk.netarkivet.common.utils.SimpleXml.add(String, String[]) 144 Normal
XFB: Method dk.netarkivet.common.utils.SimpleXml.SimpleXml(String) directly allocates a specific implementation of xml interfaces 80 Low

dk.netarkivet.common.utils.FileUtils$1

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 108 Low

dk.netarkivet.common.utils.FileUtils$3

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 128 Low

dk.netarkivet.common.utils.FileUtils$4

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 138 Low

dk.netarkivet.common.utils.FileUtils

Violation Line Priority
DLS: Dead store to bytesPerOneKilobyte in dk.netarkivet.common.utils.FileUtils.getHumanReadableFileSize(File) 1336 Normal
DLS: Dead store to bytesPerOneMegabyte in dk.netarkivet.common.utils.FileUtils.getHumanReadableFileSize(File) 1337 Normal
DLS: Dead store to bytesPerOneGigabyte in dk.netarkivet.common.utils.FileUtils.getHumanReadableFileSize(File) 1338 Normal
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.FileUtils.writeBinaryFile(File, byte[]) 520 Low
RV: dk.netarkivet.common.utils.FileUtils.countLines(File) discards result of readLine after checking if it is nonnull 794 Normal

dk.netarkivet.deploy.CreateTestInstance

Violation Line Priority
Dm: dk.netarkivet.deploy.CreateTestInstance.applyTestArguments(String, String, String, String) invokes System.exit(...), which shuts down the entire virtual machine 111 Normal

dk.netarkivet.deploy.DeployConfiguration

Violation Line Priority
Dm: dk.netarkivet.deploy.DeployConfiguration.DeployConfiguration(File, File, File, File, String, File, File, boolean, File) invokes System.exit(...), which shuts down the entire virtual machine 124 Normal
Dm: dk.netarkivet.deploy.DeployConfiguration.copyNetarchiveSuiteFile() invokes System.exit(...), which shuts down the entire virtual machine 204 Normal

dk.netarkivet.deploy.DeployApplication

Violation Line Priority
Dm: dk.netarkivet.deploy.DeployApplication.initConfigFile(String) invokes System.exit(...), which shuts down the entire virtual machine 233 Low
Dm: dk.netarkivet.deploy.DeployApplication.initArchiveDatabase(String) invokes System.exit(...), which shuts down the entire virtual machine 451 Low
Dm: dk.netarkivet.deploy.DeployApplication.initSecPolicyFile(String) invokes System.exit(...), which shuts down the entire virtual machine 298 Low
Dm: dk.netarkivet.deploy.DeployApplication.initNetarchiveSuiteFile(String) invokes System.exit(...), which shuts down the entire virtual machine 265 Low
Dm: dk.netarkivet.deploy.DeployApplication.initTestArguments(String) invokes System.exit(...), which shuts down the entire virtual machine 514 Low
Dm: dk.netarkivet.deploy.DeployApplication.initJarFolder(String) invokes System.exit(...), which shuts down the entire virtual machine 482 Low
Dm: dk.netarkivet.deploy.DeployApplication.initDatabase(String) invokes System.exit(...), which shuts down the entire virtual machine 368 Low
Dm: dk.netarkivet.deploy.DeployApplication.initLogPropFile(String) invokes System.exit(...), which shuts down the entire virtual machine 331 Low

dk.netarkivet.common.distribute.arcrepository.ReplicaType

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 82 Low

dk.netarkivet.common.distribute.ChannelID

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 56 Low
SnVI: dk.netarkivet.common.distribute.ChannelID is Serializable; consider declaring a serialVersionUID -1 Low
SBSC: Method dk.netarkivet.common.distribute.ChannelID.getApplicationAbbreviation(String) concatenates strings using + in a loop 245 Normal

dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 658 Low
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 849 Low
UwF: Field only ever set to null: dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory.ignoredSchemes 231 Low
UwF: Field only ever set to null: dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory.schemes 230 Low

dk.netarkivet.common.distribute.RemoteFileSettings

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.RemoteFileSettings is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.InputStreamUtils

Violation Line Priority
PZLA: Should dk.netarkivet.common.utils.InputStreamUtils.readRawLine(InputStream) return a zero length array rather than null? 84 Low

dk.netarkivet.common.utils.arc.ARCUtils

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.arc.ARCUtils.copySingleRecord(ARCWriter, ARCRecord) 139 Low

dk.netarkivet.common.distribute.arcrepository.BitarchiveRecord

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.arcrepository.BitarchiveRecord is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.common.utils.batch.FileBatchJob$ExceptionOccurrence

Violation Line Priority
SnVI: dk.netarkivet.common.utils.batch.FileBatchJob$ExceptionOccurrence is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.arc.ARCBatchJob

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.arc.ARCBatchJob.processFile(File, OutputStream) 188 Normal

dk.netarkivet.viewerproxy.LocalCDXCache$CDXCacheBatchJob

Violation Line Priority
SnVI: dk.netarkivet.viewerproxy.LocalCDXCache$CDXCacheBatchJob is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.SparseBitSet

Violation Line Priority
SnVI: dk.netarkivet.common.utils.SparseBitSet is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.SparseRangeFilter

Violation Line Priority
SnVI: dk.netarkivet.common.utils.SparseRangeFilter is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.arc.ARCKey

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 53 Low

dk.netarkivet.viewerproxy.ARCArchiveAccess

Violation Line Priority
PZLA: Should dk.netarkivet.viewerproxy.ARCArchiveAccess.readRawLine(InputStream) return a zero length array rather than null? 317 Low

dk.netarkivet.viewerproxy.GetDataResolver$GetFileBatchJob

Violation Line Priority
SnVI: dk.netarkivet.viewerproxy.GetDataResolver$GetFileBatchJob is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.viewerproxy.GetDataResolver$GetFileBatchJob implements same interface as superclass -1 Low

dk.netarkivet.viewerproxy.ViewerProxy

Violation Line Priority
ST: Write to static field dk.netarkivet.viewerproxy.ViewerProxy.instance from instance method dk.netarkivet.viewerproxy.ViewerProxy.cleanup() 118 High

dk.netarkivet.common.utils.ApplicationUtils

Violation Line Priority
Dm: dk.netarkivet.common.utils.ApplicationUtils.startApp(LifeCycleComponent) invokes System.exit(...), which shuts down the entire virtual machine 220 Low
Dm: dk.netarkivet.common.utils.ApplicationUtils.checkArgs(String[]) invokes System.exit(...), which shuts down the entire virtual machine 102 Low
Dm: dk.netarkivet.common.utils.ApplicationUtils.startApp(Class, String[]) invokes System.exit(...), which shuts down the entire virtual machine 160 Low

dk.netarkivet.archive.indexserver.RawMetadataCache$GetMetadataARCBatchJob

Violation Line Priority
SnVI: dk.netarkivet.archive.indexserver.RawMetadataCache$GetMetadataARCBatchJob is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.indexserver.CDXOriginCrawlLogIterator

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 107 Low

dk.netarkivet.archive.indexserver.CrawlLogIndexCache

Violation Line Priority
ITA: Method dk.netarkivet.archive.indexserver.CrawlLogIndexCache.combine(Map) uses Collection.toArray() with zero-length array argument 255 Low

dk.netarkivet.archive.indexserver.IndexServer

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.indexserver.IndexServer.instance from instance method dk.netarkivet.archive.indexserver.IndexServer.cleanup() 91 High

dk.netarkivet.archive.bitarchive.BitarchiveMonitor

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.bitarchive.BitarchiveMonitor.instance from instance method dk.netarkivet.archive.bitarchive.BitarchiveMonitor.cleanup() 293 High

dk.netarkivet.archive.bitarchive.BitarchiveAdmin

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.bitarchive.BitarchiveAdmin.instance from instance method dk.netarkivet.archive.bitarchive.BitarchiveAdmin.close() 576 High

dk.netarkivet.common.utils.batch.BatchLocalFiles

Violation Line Priority
EI2: dk.netarkivet.common.utils.batch.BatchLocalFiles.BatchLocalFiles(File[]) may expose internal representation by storing an externally mutable object into BatchLocalFiles.files 74 Normal
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.batch.BatchLocalFiles.run(FileBatchJob, OutputStream) 128 Low

dk.netarkivet.archive.bitarchive.Bitarchive

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.bitarchive.Bitarchive.instance from instance method dk.netarkivet.archive.bitarchive.Bitarchive.close() 90 High

dk.netarkivet.archive.bitarchive.distribute.BatchMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.BatchMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.BatchTerminationMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.BatchTerminationMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.BatchEndedMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.BatchEndedMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.distribute.JMSConnection

Violation Line Priority
ST: Write to static field dk.netarkivet.common.distribute.JMSConnection.instance from instance method dk.netarkivet.common.distribute.JMSConnection.cleanup() 338 Normal
MS: dk.netarkivet.common.distribute.JMSConnection.instance should be package protected -1 Low

dk.netarkivet.common.distribute.NullRemoteFile

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.NullRemoteFile is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.GetFileMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.GetFileMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.GetMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.GetMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.HeartBeatMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.HeartBeatMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.RemoveAndGetFileMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.RemoveAndGetFileMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.UploadMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.UploadMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.instance from instance method dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.cleanup() 244 High
UW: Unconditional wait in dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.visit(BatchTerminationMessage) 488 Low
Wa: Wait not in loop in dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.visit(BatchTerminationMessage) 488 Low
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.visit(RemoveAndGetFileMessage) 397 Low

dk.netarkivet.archive.bitarchive.distribute.BatchReplyMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.bitarchive.distribute.BatchReplyMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.checksum.distribute.CorrectMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.checksum.distribute.CorrectMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.checksum.distribute.GetAllChecksumsMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.checksum.distribute.GetAllChecksumsMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.checksum.distribute.GetAllFilenamesMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.checksum.distribute.GetAllFilenamesMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.checksum.distribute.GetChecksumMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.checksum.distribute.GetChecksumMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.batch.ChecksumJob

Violation Line Priority
SnVI: dk.netarkivet.common.utils.batch.ChecksumJob is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.common.utils.batch.FileListJob

Violation Line Priority
SnVI: dk.netarkivet.common.utils.batch.FileListJob is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.archive.bitarchive.distribute.BitarchiveMonitorServer

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.bitarchive.distribute.BitarchiveMonitorServer.visit(BatchMessage) 196 Low
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.bitarchive.distribute.BitarchiveMonitorServer.visit(RemoveAndGetFileMessage) 349 Low
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.bitarchive.distribute.BitarchiveMonitorServer.doBatchReply(BitarchiveMonitor$BatchJobStatus) 575 Low

dk.netarkivet.archive.arcrepository.distribute.StoreMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.arcrepository.distribute.StoreMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.arcrepositoryadmin.ArchiveStoreState

Violation Line Priority
EI2: dk.netarkivet.archive.arcrepositoryadmin.ArchiveStoreState.setState(ReplicaStoreState, Date) may expose internal representation by storing an externally mutable object into ArchiveStoreState.lastchanged 83 Normal
EI: dk.netarkivet.archive.arcrepositoryadmin.ArchiveStoreState.getLastChanged() may expose internal representation by returning ArchiveStoreState.lastchanged 104 Normal

dk.netarkivet.archive.arcrepositoryadmin.AdminData

Violation Line Priority
NP: Load of known null value in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readValidOldVersion(BufferedReader) 344 Low
NP: Load of known null value in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 509 Low
DLS: Dead store to indexFirstPartTimestamp in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 435 Low
DLS: Dead store to firstPartLength in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 429 Low
DLS: Dead store to indexFirstPartState in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 434 Low
DLS: Dead store to indexOtherPartsTimestamp in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 443 Low
DLS: Dead store to timestampAsDate in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 489 Normal
DLS: Dead store to otherPartsLength in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 438 Low
DLS: Dead store to state in dk.netarkivet.archive.arcrepositoryadmin.AdminData.readCurrentVersion(BufferedReader) 486 Low

dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection

Violation Line Priority
RCN: Redundant nullcheck of dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection.dataSource, which is known to be non-null in dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection.cleanup() 160 Low
Dm: Method dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection.initDataSource(DBSpecifics, String) invokes toString() method on a String 289 Normal
SWL: dk.netarkivet.archive.arcrepositoryadmin.ArchiveDBConnection.get() calls Thread.sleep() with a lock held 125 Normal

dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers.insertFileIntoDB(String, Connection) 152 High
DLS: Dead store to message in dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers.getReplicaFileInfo(long, Connection) 868 Low
CI: Class dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers is final but declares protected field dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers.log -1 Low
MS: dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheHelpers.log isn't final but should be 58 High

dk.netarkivet.archive.arcrepositoryadmin.DerbyEmbeddedSpecifics

Violation Line Priority
ODR: dk.netarkivet.archive.arcrepositoryadmin.DerbyEmbeddedSpecifics.shutdownDatabase() may fail to close java.sql.Connection 64 Normal

dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.instance from instance method dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.cleanup() 1659 High
DLS: Dead store to lengthOtherParts in dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.insertAdminEntry(String) 1420 Low
DLS: Dead store to lengthFirstPart in dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.insertAdminEntry(String) 1419 Low
DLS: Dead store to sql in dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.isEmpty() 1520 Low
CI: Class dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase is final but declares protected field dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.log -1 Low
SS: Unread field: dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.INIT_DB_RETRIES; should this field be static? 94 Normal
SS: Unread field: dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.LOGGING_ENTRY_INTERVAL; should this field be static? 86 Normal
SS: Unread field: dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.WAIT_BEFORE_INIT_RETRY; should this field be static? 91 Normal
MS: dk.netarkivet.archive.arcrepositoryadmin.ReplicaCacheDatabase.log isn't final but should be 74 High

dk.netarkivet.archive.arcrepositoryadmin.DatabaseAdmin

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepositoryadmin.DatabaseAdmin.instance from instance method dk.netarkivet.archive.arcrepositoryadmin.DatabaseAdmin.close() 349 High

dk.netarkivet.common.tools.ToolRunnerBase

Violation Line Priority
Dm: dk.netarkivet.common.tools.ToolRunnerBase.runTheTool(String[]) invokes System.exit(...), which shuts down the entire virtual machine 76 Normal

dk.netarkivet.archive.tools.CreateIndex

Violation Line Priority
NP: Possible null pointer dereference of cmd in dk.netarkivet.archive.tools.CreateIndex.main(String[]) on exception path 95 Normal
NP: Possible null pointer dereference of cache in dk.netarkivet.archive.tools.CreateIndex.main(String[]) 122 High
DLS: Dead store to index in dk.netarkivet.archive.tools.CreateIndex.main(String[]) 122 Normal

dk.netarkivet.archive.tools.ReestablishAdminDatabase$ReestablishAdminDatabaseTool

Violation Line Priority
NP: Possible null pointer dereference in dk.netarkivet.archive.tools.ReestablishAdminDatabase$ReestablishAdminDatabaseTool.run(String[]) due to return value of called method 159 Normal

dk.netarkivet.archive.tools.GetFile$GetFileTool

Violation Line Priority
Dm: dk.netarkivet.archive.tools.GetFile$GetFileTool.run(String[]) invokes System.exit(...), which shuts down the entire virtual machine 149 Normal

dk.netarkivet.archive.tools.RunBatch$RunBatchTool$BatchParameters

Violation Line Priority
SBSC: Method dk.netarkivet.archive.tools.RunBatch$RunBatchTool$BatchParameters.listArguments() concatenates strings using + in a loop 327 Normal
SIC: The class dk.netarkivet.archive.tools.RunBatch$RunBatchTool$BatchParameters could be refactored into a _static_ inner class -1 Low

dk.netarkivet.common.utils.batch.ByteClassLoader

Violation Line Priority
EI2: dk.netarkivet.common.utils.batch.ByteClassLoader.ByteClassLoader(byte[]) may expose internal representation by storing an externally mutable object into ByteClassLoader.binaryData 53 Normal

dk.netarkivet.common.utils.batch.LoadableFileBatchJob

Violation Line Priority
DP: dk.netarkivet.common.utils.batch.LoadableFileBatchJob.loadBatchJob() creates a dk.netarkivet.common.utils.batch.ByteClassLoader classloader, which should be performed within a doPrivileged block 130 Normal
SnVI: dk.netarkivet.common.utils.batch.LoadableFileBatchJob is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.common.utils.batch.ByteJarLoader

Violation Line Priority
Se: The field dk.netarkivet.common.utils.batch.ByteJarLoader.log is transient but isn't set by deserialization -1 Normal
SnVI: dk.netarkivet.common.utils.batch.ByteJarLoader is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.common.utils.batch.LoadableJarBatchJob

Violation Line Priority
DP: dk.netarkivet.common.utils.batch.LoadableJarBatchJob.LoadableJarBatchJob(String, List, File[]) creates a dk.netarkivet.common.utils.batch.ByteJarLoader classloader, which should be performed within a doPrivileged block 91 Normal
SnVI: dk.netarkivet.common.utils.batch.LoadableJarBatchJob is Serializable; consider declaring a serialVersionUID -1 Normal
Se: Class dk.netarkivet.common.utils.batch.LoadableJarBatchJob defines non-transient non-serializable instance field multipleClassLoader -1 Low

dk.netarkivet.archive.tools.RunBatch$RunBatchTool

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 202 Low
RV: dk.netarkivet.archive.tools.RunBatch$RunBatchTool.checkWriteFile(String, String) ignores return value of java.io.File.createNewFile() 233 Low

dk.netarkivet.common.webinterface.HTMLUtils

Violation Line Priority
SBSC: Method dk.netarkivet.common.webinterface.HTMLUtils.generateHeader(String, PageContext, String[]) concatenates strings using + in a loop 243 Normal

dk.netarkivet.common.webinterface.SiteSection

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.webinterface.SiteSection.getSections() 244 Low

dk.netarkivet.archive.webinterface.BatchExecuter

Violation Line Priority
OS: dk.netarkivet.archive.webinterface.BatchExecuter.run() may fail to close stream on exception 134 Low
RV: dk.netarkivet.archive.webinterface.BatchExecuter.run() ignores return value of java.io.File.createNewFile() 124 Low
RV: dk.netarkivet.archive.webinterface.BatchExecuter.run() ignores return value of java.io.File.createNewFile() 128 Low

dk.netarkivet.archive.webinterface.BatchGUI

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.webinterface.BatchGUI.execute(PageContext) 276 Normal

dk.netarkivet.archive.arcrepository.bitpreservation.AdminDataMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.arcrepository.bitpreservation.AdminDataMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.archive.arcrepository.ArcRepository

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepository.ArcRepository.instance from instance method dk.netarkivet.archive.arcrepository.ArcRepository.cleanup() 1112 High
IS: Inconsistent synchronization of dk.netarkivet.archive.arcrepository.ArcRepository.ad; locked 73% of time 1061 Normal

dk.netarkivet.archive.checksum.FileChecksumArchive

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.checksum.FileChecksumArchive.instance from instance method dk.netarkivet.archive.checksum.FileChecksumArchive.cleanup() 903 High
OS: dk.netarkivet.archive.checksum.FileChecksumArchive.recreateArchiveFile() may fail to close stream on exception 458 Low
OS: dk.netarkivet.archive.checksum.FileChecksumArchive.appendEntryToFile(String, String) may fail to close stream on exception 563 Low
OS: dk.netarkivet.archive.checksum.FileChecksumArchive.appendWrongRecordToWrongEntryFile(String) may fail to close stream on exception 598 Low
OS: dk.netarkivet.archive.checksum.FileChecksumArchive.correct(String, File) may fail to close stream on exception 790 Low
OS: dk.netarkivet.archive.checksum.FileChecksumArchive.getAllFilenames() may fail to close stream on exception 851 Low
DLS: Dead store to lineLength in dk.netarkivet.archive.checksum.FileChecksumArchive.loadAdminData() 361 Low
RV: dk.netarkivet.archive.checksum.FileChecksumArchive.initializeFiles() ignores return value of java.io.File.createNewFile() 261 Low
Nm: Confusing to have methods dk.netarkivet.archive.checksum.FileChecksumArchive.getChecksum(String) and dk.netarkivet.archive.arcrepositoryadmin.AdminData.getCheckSum(String) 671 Low
Nm: Confusing to have methods dk.netarkivet.archive.checksum.FileChecksumArchive.getFileName() and dk.netarkivet.archive.arcrepositoryadmin.ArcRepositoryEntry.getFilename() 184 Low
IS: Inconsistent synchronization of dk.netarkivet.archive.checksum.FileChecksumArchive.lastModifiedChecksumFile; locked 50% of time 337 Normal

dk.netarkivet.archive.checksum.distribute.ChecksumFileServer

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.checksum.distribute.ChecksumFileServer.instance from instance method dk.netarkivet.archive.checksum.distribute.ChecksumFileServer.cleanup() 138 High
MS: dk.netarkivet.archive.checksum.distribute.ChecksumFileServer.instance should be package protected -1 Normal

dk.netarkivet.wayback.aggregator.IndexAggregator

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.wayback.aggregator.IndexAggregator.processFiles(File[], File, List) 141 Normal

dk.netarkivet.wayback.batch.ExtractDeduplicateCDXBatchJob

Violation Line Priority
SnVI: dk.netarkivet.wayback.batch.ExtractDeduplicateCDXBatchJob is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.wayback.batch.ExtractDeduplicateCDXBatchJob defines non-transient non-serializable instance field adapter -1 Normal

dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob

Violation Line Priority
SnVI: dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob defines non-transient non-serializable instance field log -1 Normal
Se: Class dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob defines non-transient non-serializable instance field aToSAdapter -1 Normal
Se: Class dk.netarkivet.wayback.batch.ExtractWaybackCDXBatchJob defines non-transient non-serializable instance field srToCDXAdapter -1 Normal

dk.netarkivet.wayback.indexer.ArchiveFile

Violation Line Priority
EI: dk.netarkivet.wayback.indexer.ArchiveFile.getIndexedDate() may expose internal representation by returning ArchiveFile.indexedDate 117 Normal
EI2: dk.netarkivet.wayback.indexer.ArchiveFile.setIndexedDate(Date) may expose internal representation by storing an externally mutable object into ArchiveFile.indexedDate 125 Normal
SBSC: Method dk.netarkivet.wayback.indexer.ArchiveFile.logBatchError(BatchStatus) concatenates strings using + in a loop 286 Normal
UwF: ArchiveFile.filename not initialized in constructor -1 Low

dk.netarkivet.wayback.indexer.IndexerQueue

Violation Line Priority
ST: Write to static field dk.netarkivet.wayback.indexer.IndexerQueue.queue from instance method dk.netarkivet.wayback.indexer.IndexerQueue.IndexerQueue() 73 Normal

dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp

Violation Line Priority
SnVI: dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp defines non-transient non-serializable instance field log -1 Normal

dk.netarkivet.common.utils.FixedUURI

Violation Line Priority
SnVI: dk.netarkivet.common.utils.FixedUURI is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob

Violation Line Priority
SnVI: dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob defines non-transient non-serializable instance field log -1 Normal

dk.netarkivet.common.utils.cdx.ExtractCDXJob

Violation Line Priority
SnVI: dk.netarkivet.common.utils.cdx.ExtractCDXJob is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.common.utils.cdx.ExtractCDXJob defines non-transient non-serializable instance field log -1 Normal

dk.netarkivet.monitor.jmx.RmiProxyConnectionFactory$MBeanServerProxyConnection

Violation Line Priority
UW: Unconditional wait in dk.netarkivet.monitor.jmx.RmiProxyConnectionFactory$MBeanServerProxyConnection.waitForConnection() 177 Low

dk.netarkivet.common.distribute.monitorregistry.HostEntry

Violation Line Priority
EI: dk.netarkivet.common.distribute.monitorregistry.HostEntry.getTime() may expose internal representation by returning HostEntry.time 99 Normal
EI2: dk.netarkivet.common.distribute.monitorregistry.HostEntry.setTime(Date) may expose internal representation by storing an externally mutable object into HostEntry.time 163 Normal
SnVI: dk.netarkivet.common.distribute.monitorregistry.HostEntry is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.management.SingleMBeanObject

Violation Line Priority
EI: dk.netarkivet.common.management.SingleMBeanObject.getNameProperties() may expose internal representation by returning SingleMBeanObject.nameProperties 175 Normal

dk.netarkivet.monitor.jmx.HostForwarding

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.monitor.jmx.HostForwarding.registerRemoteMbeans(List) 324 Low
REC: Exception is caught when Exception is not thrown in dk.netarkivet.monitor.jmx.HostForwarding.createProxyMBeansForHost(HostEntry) 369 Low

dk.netarkivet.monitor.distribute.MonitorMessage

Violation Line Priority
RI: Class dk.netarkivet.monitor.distribute.MonitorMessage implements same interface as superclass -1 Low

dk.netarkivet.monitor.registry.distribute.RegisterHostMessage

Violation Line Priority
SnVI: dk.netarkivet.monitor.registry.distribute.RegisterHostMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.monitor.logging.CachingLogHandler

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.monitor.logging.CachingLogHandler.getFilterProperty(String, Filter) 107 Low
REC: Exception is caught when Exception is not thrown in dk.netarkivet.monitor.logging.CachingLogHandler.getFormatterProperty(String, Formatter) 140 Low

dk.netarkivet.monitor.tools.JMXProxy$1

Violation Line Priority
UW: Unconditional wait in dk.netarkivet.monitor.tools.JMXProxy$1.run(String[]) 105 Normal
Wa: Wait not in loop in dk.netarkivet.monitor.tools.JMXProxy$1.run(String[]) 105 Normal
SIC: The class dk.netarkivet.monitor.tools.JMXProxy$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.monitor.webinterface.JMXStatusEntry

Violation Line Priority
Eq: dk.netarkivet.monitor.webinterface.JMXStatusEntry defines compareTo(Object) and uses Object.equals() 52 Normal
Nm: Confusing to have methods dk.netarkivet.monitor.webinterface.JMXStatusEntry.getApplicationInstanceID() and dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage.getApplicationInstanceId() 118 Low

dk.netarkivet.monitor.webinterface.JMXSummaryUtils

Violation Line Priority
RCN: Redundant nullcheck of query, which is known to be non-null in dk.netarkivet.monitor.webinterface.JMXSummaryUtils.queryJMXFromRequest(String[], JMXSummaryUtils$StarredRequest, PageContext) 340 Low
RCN: Redundant nullcheck of query, which is known to be non-null in dk.netarkivet.monitor.webinterface.JMXSummaryUtils.unregisterJMXInstance(String[], JMXSummaryUtils$StarredRequest, PageContext) 370 Low
MS: dk.netarkivet.monitor.webinterface.JMXSummaryUtils.STARRABLE_PARAMETERS should be package protected 95 Normal

dk.netarkivet.harvester.datamodel.DerbySpecifics

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DerbySpecifics.dropJobConfigsTmpTable(Connection, String) 84 Low

dk.netarkivet.harvester.datamodel.HarvestDBConnection

Violation Line Priority
RCN: Redundant nullcheck of dk.netarkivet.harvester.datamodel.HarvestDBConnection.dataSource, which is known to be non-null in dk.netarkivet.harvester.datamodel.HarvestDBConnection.cleanup() 231 Low
Dm: Method dk.netarkivet.harvester.datamodel.HarvestDBConnection.initDataSource(DBSpecifics, String) invokes toString() method on a String 321 Normal

dk.netarkivet.harvester.datamodel.HarvestInfo

Violation Line Priority
EI2: dk.netarkivet.harvester.datamodel.HarvestInfo.HarvestInfo(Long, Long, String, String, Date, long, long, StopReason) may expose internal representation by storing an externally mutable object into HarvestInfo.date 112 Normal
EI: dk.netarkivet.harvester.datamodel.HarvestInfo.getDate() may expose internal representation by returning HarvestInfo.date 147 Normal

dk.netarkivet.harvester.datamodel.GlobalCrawlerTrapListDBDAO

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.GlobalCrawlerTrapListDBDAO.create(GlobalCrawlerTrapList) 174 Low

dk.netarkivet.harvester.datamodel.SeedList

Violation Line Priority
SnVI: dk.netarkivet.harvester.datamodel.SeedList is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.Job

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.Job.getActualStop() may expose internal representation by returning Job.actualStop 749 Normal
EI: dk.netarkivet.harvester.datamodel.Job.getActualStart() may expose internal representation by returning Job.actualStart 758 Normal
EI: dk.netarkivet.harvester.datamodel.Job.getSubmittedDate() may expose internal representation by returning Job.submittedDate 765 Normal
EI: dk.netarkivet.harvester.datamodel.Job.getSettingsXMLfiles() may expose internal representation by returning Job.settingsXMLfiles 778 Normal
EI: dk.netarkivet.harvester.datamodel.Job.getSettingsXMLdocs() may expose internal representation by returning Job.settingsXMLdocs 886 Normal
EI2: dk.netarkivet.harvester.datamodel.Job.setSubmittedDate(Date) may expose internal representation by storing an externally mutable object into Job.submittedDate 1487 Normal
SnVI: dk.netarkivet.harvester.datamodel.Job is Serializable; consider declaring a serialVersionUID -1 Normal
UwF: Unwritten field: dk.netarkivet.harvester.datamodel.Job.settingsXMLdocs 886 Normal
UwF: Unwritten field: dk.netarkivet.harvester.datamodel.Job.settingsXMLfiles 778 Normal

dk.netarkivet.harvester.datamodel.HarvestDefinition$CompareConfigsDesc

Violation Line Priority
Se: dk.netarkivet.harvester.datamodel.HarvestDefinition$CompareConfigsDesc implements Comparator but not Serializable -1 Normal

dk.netarkivet.harvester.datamodel.JobDBDAO$HarvestStatusQueryBuilder

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.JobDBDAO$HarvestStatusQueryBuilder.getPopulatedStatement(Connection) 1083 Low
SIC: Should dk.netarkivet.harvester.datamodel.JobDBDAO$HarvestStatusQueryBuilder be a _static_ inner class? -1 Normal

dk.netarkivet.harvester.datamodel.JobStatusInfo

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.JobStatusInfo.getSubmittedDate() may expose internal representation by returning JobStatusInfo.submittedDate 173 Normal
EI: dk.netarkivet.harvester.datamodel.JobStatusInfo.getStartDate() may expose internal representation by returning JobStatusInfo.startDate 181 Normal
EI: dk.netarkivet.harvester.datamodel.JobStatusInfo.getEndDate() may expose internal representation by returning JobStatusInfo.endDate 188 Normal

dk.netarkivet.harvester.datamodel.JobDBDAO

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 1167 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.JobDBDAO.createJobConfigsEntries(Connection, Job) 200 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.JobDBDAO.createJobConfigsEntries(Connection, Job) 213 Normal
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.JobDBDAO.read(Connection, Long) 488 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.JobDBDAO.getStatusInfo(Connection, int, boolean) 708 Low

dk.netarkivet.harvester.datamodel.RepeatingSchedule

Violation Line Priority
SnVI: dk.netarkivet.harvester.datamodel.RepeatingSchedule is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.TimedSchedule

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.TimedSchedule.getEndDate() may expose internal representation by returning TimedSchedule.endDate 123 Normal
SnVI: dk.netarkivet.harvester.datamodel.TimedSchedule is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.Schedule

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.Schedule.getStartDate() may expose internal representation by returning Schedule.startDate 159 Normal
UwF: Schedule.id not initialized in constructor -1 Low

dk.netarkivet.harvester.datamodel.ScheduleDBDAO

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.ScheduleDBDAO.create(Schedule) 92 Low
DLS: Dead store to fieldNum in dk.netarkivet.harvester.datamodel.ScheduleDBDAO.setScheduleParameters(PreparedStatement, Schedule) 125 Low

dk.netarkivet.harvester.datamodel.PartialHarvest

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.PartialHarvest.getNextDate() may expose internal representation by returning PartialHarvest.nextDate 208 Normal
EI2: dk.netarkivet.harvester.datamodel.PartialHarvest.setNextDate(Date) may expose internal representation by storing an externally mutable object into PartialHarvest.nextDate 218 Normal

dk.netarkivet.harvester.harvesting.HeritrixLauncher

Violation Line Priority
EI2: dk.netarkivet.harvester.harvesting.HeritrixLauncher.HeritrixLauncher(Object[]) may expose internal representation by storing an externally mutable object into HeritrixLauncher.args 138 Normal
UrF: Unread field: dk.netarkivet.harvester.harvesting.HeritrixLauncher.log 78 Low

dk.netarkivet.harvester.datamodel.HarvestDefinition

Violation Line Priority
EI2: dk.netarkivet.harvester.datamodel.HarvestDefinition.setSubmissionDate(Date) may expose internal representation by storing an externally mutable object into HarvestDefinition.submissionDate 189 Normal
EI: dk.netarkivet.harvester.datamodel.HarvestDefinition.getSubmissionDate() may expose internal representation by returning HarvestDefinition.submissionDate 198 Normal

dk.netarkivet.harvester.datamodel.DomainHarvestInfo

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.DomainHarvestInfo.getStartDate() may expose internal representation by returning DomainHarvestInfo.startDate 148 Normal
EI: dk.netarkivet.harvester.datamodel.DomainHarvestInfo.getEndDate() may expose internal representation by returning DomainHarvestInfo.endDate 156 Normal

dk.netarkivet.harvester.datamodel.DomainOwnerInfo

Violation Line Priority
Eq: dk.netarkivet.harvester.datamodel.DomainOwnerInfo defines compareTo(Object) and uses Object.equals() 114 Normal
EI2: dk.netarkivet.harvester.datamodel.DomainOwnerInfo.DomainOwnerInfo(Date, String) may expose internal representation by storing an externally mutable object into DomainOwnerInfo.date 55 Normal
EI: dk.netarkivet.harvester.datamodel.DomainOwnerInfo.getDate() may expose internal representation by returning DomainOwnerInfo.date 73 Normal
UwF: DomainOwnerInfo.id not initialized in constructor -1 Low

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldOptions

Violation Line Priority
SBSC: Method dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldOptions.getOptionsString() concatenates strings using + in a loop 119 Normal

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedField

Violation Line Priority
SnVI: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedField is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDefaultValue

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 138 Low
DB: Method dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDefaultValue.validate() uses the same code for two switch clauses 85 Low

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldValue

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 141 Low

dk.netarkivet.harvester.datamodel.DomainDBDAO

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.create(Connection, Domain) 124 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.insertHarvestInfo(Connection, Domain, HarvestInfo) 636 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.insertOwnerInfo(Connection, Domain, DomainOwnerInfo) 679 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.insertSeedlist(Connection, Domain, SeedList) 704 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.insertPassword(Connection, Domain, Password) 732 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.insertConfiguration(Connection, Domain, DomainConfiguration) 774 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.deleteConfigFromTable(Connection, long, String) 813 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.DomainDBDAO.getDomainHarvestInfo(String, boolean) 1563 Low
ODR: dk.netarkivet.harvester.datamodel.DomainDBDAO.getDomainConfiguration(String, String) may fail to close database resource on exception 1720 Low
ODR: dk.netarkivet.harvester.datamodel.DomainDBDAO.getDomainConfiguration(String, String) may fail to close database resource on exception 1743 Low

dk.netarkivet.harvester.datamodel.Domain

Violation Line Priority
ITA: Method dk.netarkivet.harvester.datamodel.Domain.getAllDomainOwnerInfo() uses Collection.toArray() with zero-length array argument 722 Low

dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$SparseDomainConfigurationComparator

Violation Line Priority
Se: dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$SparseDomainConfigurationComparator implements Comparator but not Serializable -1 Normal

dk.netarkivet.harvester.datamodel.HarvestRunInfo

Violation Line Priority
EI: dk.netarkivet.harvester.datamodel.HarvestRunInfo.getStartDate() may expose internal representation by returning HarvestRunInfo.startDate 78 Normal
EI: dk.netarkivet.harvester.datamodel.HarvestRunInfo.getEndDate() may expose internal representation by returning HarvestRunInfo.endDate 82 Normal
EI2: dk.netarkivet.harvester.datamodel.HarvestRunInfo.setStartDate(Date) may expose internal representation by storing an externally mutable object into HarvestRunInfo.startDate 121 Normal
EI2: dk.netarkivet.harvester.datamodel.HarvestRunInfo.setEndDate(Date) may expose internal representation by storing an externally mutable object into HarvestRunInfo.endDate 128 Normal

dk.netarkivet.harvester.datamodel.SparsePartialHarvest

Violation Line Priority
EI2: dk.netarkivet.harvester.datamodel.SparsePartialHarvest.SparsePartialHarvest(Long, String, String, int, Date, boolean, long, String, Date) may expose internal representation by storing an externally mutable object into SparsePartialHarvest.submissionDate 105 Normal
EI: dk.netarkivet.harvester.datamodel.SparsePartialHarvest.getNextDate() may expose internal representation by returning SparsePartialHarvest.nextDate 119 Normal
EI: dk.netarkivet.harvester.datamodel.SparsePartialHarvest.getSubmissionDate() may expose internal representation by returning SparsePartialHarvest.submissionDate 188 Normal

dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO

Violation Line Priority
ODR: dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO.addDomainConfiguration(PartialHarvest, SparseDomainConfiguration) may fail to close database resource on exception 1526 Low

dk.netarkivet.harvester.distribute.HarvesterMessage

Violation Line Priority
RI: Class dk.netarkivet.harvester.distribute.HarvesterMessage implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.distribute.PersistentJobData$HarvestDefinitionInfo

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.PersistentJobData$HarvestDefinitionInfo is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.distribute.PersistentJobData

Violation Line Priority
DLS: Dead store to errMsg in dk.netarkivet.harvester.harvesting.distribute.PersistentJobData.validateHarvestInfo(SimpleXml) 321 Low
Nm: Confusing to have methods dk.netarkivet.harvester.harvesting.distribute.PersistentJobData.getOrderXMLName() and dk.netarkivet.harvester.datamodel.DomainConfiguration.getOrderXmlName() 503 Low

dk.netarkivet.harvester.harvesting.distribute.DoOneCrawlMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.DoOneCrawlMessage is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.distribute.DoOneCrawlMessage implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.distribute.MetadataEntry

Violation Line Priority
EI: dk.netarkivet.harvester.harvesting.distribute.MetadataEntry.getData() may expose internal representation by returning MetadataEntry.data 216 Normal
SnVI: dk.netarkivet.harvester.harvesting.distribute.MetadataEntry is Serializable; consider declaring a serialVersionUID -1 Low
Nm: Confusing to have methods dk.netarkivet.harvester.harvesting.distribute.MetadataEntry.getURL() and dk.netarkivet.harvester.harvesting.MetadataFile.getUrl() 244 Low

dk.netarkivet.harvester.scheduler.JobDispatcher

Violation Line Priority
RCN: Redundant nullcheck of jobToSubmit, which is known to be non-null in dk.netarkivet.harvester.scheduler.JobDispatcher.submitNextNewJob(JobPriority) 126 Low

dk.netarkivet.common.lifecycle.PeriodicTaskExecutor

Violation Line Priority
EI2: dk.netarkivet.common.lifecycle.PeriodicTaskExecutor.PeriodicTaskExecutor(PeriodicTaskExecutor$PeriodicTask[]) may expose internal representation by storing an externally mutable object into PeriodicTaskExecutor.tasks 171 Normal
SBSC: Method dk.netarkivet.common.lifecycle.PeriodicTaskExecutor.PeriodicTaskExecutor(PeriodicTaskExecutor$PeriodicTask[]) concatenates strings using + in a loop 184 Normal

dk.netarkivet.harvester.scheduler.HarvestJobGenerator$JobGeneratorTask$1

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.harvester.scheduler.HarvestJobGenerator$JobGeneratorTask$1.run() 165 Low

dk.netarkivet.harvester.distribute.IndexReadyMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.distribute.IndexReadyMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceInfo

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceInfo is Serializable; consider declaring a serialVersionUID -1 Low
SIC: Should dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceInfo be a _static_ inner class? -1 Normal

dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceJobInfo

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceJobInfo is Serializable; consider declaring a serialVersionUID -1 Low
SIC: Should dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage$CrawlServiceJobInfo be a _static_ inner class? -1 Normal

dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO$FR_COLUMN

Violation Line Priority
SBSC: Method dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO$FR_COLUMN.getColumnsInOrder() concatenates strings using + in a loop 771 Normal

dk.netarkivet.harvester.harvesting.frontier.FrontierReportLineNaturalOrder

Violation Line Priority
Se: dk.netarkivet.harvester.harvesting.frontier.FrontierReportLineNaturalOrder implements Comparator but not Serializable -1 Low

dk.netarkivet.harvester.harvesting.frontier.FrontierReportLine

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.frontier.FrontierReportLine is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.frontier.InMemoryFrontierReport

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.frontier.InMemoryFrontierReport is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.frontier.InMemoryFrontierReport implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo

Violation Line Priority
Bx: Method dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo.compareTo(StartedJobInfo) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead 371 Low
Eq: dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo defines compareTo(StartedJobInfo) and uses Object.equals() 363 Normal
EI: dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo.getTimestamp() may expose internal representation by returning StartedJobInfo.timestamp 223 Normal
EI2: dk.netarkivet.harvester.harvesting.monitor.StartedJobInfo.setTimestamp(Date) may expose internal representation by storing an externally mutable object into StartedJobInfo.timestamp 629 Normal

dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.store(StartedJobInfo) 212 Normal
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.store(StartedJobInfo) 309 Normal
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.getFullJobHistory(long) 402 Low
SQL: Method dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.getMostRecentByHarvestName() passes a nonconstant String to an execute method on an SQL statement 444 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.getMostRecentByJobId(long, long, int) 589 Low
SQL: Method dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.getMostRecentByJobId(long) passes a nonconstant String to an execute method on an SQL statement 629 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.storeFrontierReport(String, InMemoryFrontierReport) 824 Low
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.RunningJobsInfoDBDAO.getFrontierReport(long, String) 954 Low

dk.netarkivet.harvester.harvesting.distribute.FrontierReportMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.FrontierReportMessage is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.distribute.JobEndedMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.JobEndedMessage is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.distribute.JobEndedMessage implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLineKey

Violation Line Priority
Eq: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLineKey defines compareTo(FullFrontierReport$PersistentLineKey) and uses Object.equals() 101 Normal

dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLine

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLine is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$PersistentLine defines non-transient non-serializable instance field primaryKey -1 Normal

dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field dbEnvironment -1 Normal
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field store -1 Normal
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field linesIndex -1 Normal
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field linesByDomain -1 Normal
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field linesByCurrentSize -1 Normal
Se: Class dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport defines non-transient non-serializable instance field linesBySpentBudget -1 Normal
OS: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport.parseContentsAsString(String, String) may fail to close stream on exception 422 Low
OS: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport.parseContentsAsString(String, String) may fail to close stream on exception 432 Low
DLS: Dead store to lineToken in dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport.parseContentsAsString(String, String) 439 Low
RV: dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport.parseContentsAsString(String, String) ignores return value of java.io.File.createNewFile() 421 Low

dk.netarkivet.harvester.harvesting.frontier.ExhaustedQueuesFilter

Violation Line Priority
BC: Unchecked/unconfirmed cast from dk.netarkivet.harvester.harvesting.frontier.FrontierReport to dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport in dk.netarkivet.harvester.harvesting.frontier.ExhaustedQueuesFilter.process(FrontierReport) 41 Low

dk.netarkivet.harvester.harvesting.frontier.RetiredQueuesFilter

Violation Line Priority
BC: Unchecked/unconfirmed cast from dk.netarkivet.harvester.harvesting.frontier.FrontierReport to dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport in dk.netarkivet.harvester.harvesting.frontier.RetiredQueuesFilter.process(FrontierReport) 39 Low

dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor

Violation Line Priority
ST: Write to static field dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor.instance from instance method dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor.cleanup() 110 High
RI: Class dk.netarkivet.harvester.harvesting.monitor.HarvestMonitor implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.distribute.CrawlProgressMessage implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.distribute.CrawlStatusMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.CrawlStatusMessage is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.distribute.CrawlStatusMessage implements same interface as superclass -1 Low
Nm: Confusing to have methods dk.netarkivet.harvester.harvesting.distribute.CrawlStatusMessage.getJobID() and dk.netarkivet.harvester.harvesting.distribute.JobEndedMessage.getJobId() 102 Low

dk.netarkivet.harvester.scheduler.HarvestSchedulerMonitorServer

Violation Line Priority
RI: Class dk.netarkivet.harvester.scheduler.HarvestSchedulerMonitorServer implements same interface as superclass -1 Low

dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage is Serializable; consider declaring a serialVersionUID -1 Low
RI: Class dk.netarkivet.harvester.harvesting.distribute.HarvesterReadyMessage implements same interface as superclass -1 Low

dk.netarkivet.common.utils.cdx.CDXUtils

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.cdx.CDXUtils.generateCDX(File, File) 137 Low

dk.netarkivet.harvester.harvesting.ArcFilesReportGenerator

Violation Line Priority
OS: dk.netarkivet.harvester.harvesting.ArcFilesReportGenerator.parseHeritrixOut() may fail to close stream on exception 218 Low

dk.netarkivet.harvester.harvesting.MetadataFile

Violation Line Priority
Eq: dk.netarkivet.harvester.harvesting.MetadataFile defines compareTo(MetadataFile) and uses Object.equals() 195 Normal

dk.netarkivet.harvester.harvesting.HarvestDocumentation

Violation Line Priority
SBSC: Method dk.netarkivet.harvester.harvesting.HarvestDocumentation.reverseDomainString(String) concatenates strings using + in a loop 680 Normal

dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$CrawlStatus

Violation Line Priority
SWL: dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$CrawlStatus.sendStatus() calls Thread.sleep() with a lock held 848 Normal
IS: Inconsistent synchronization of dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$CrawlStatus.running; locked 50% of time 807 Low

dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$HarvesterThread

Violation Line Priority
Dm: dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer$HarvesterThread.shutdownNowOrContinue() invokes System.exit(...), which shuts down the entire virtual machine 749 Normal

dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer

Violation Line Priority
ST: Write to static field dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer.instance from instance method dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer.cleanup() 292 High
SWL: dk.netarkivet.harvester.harvesting.distribute.HarvestControllerServer.onDoOneCrawl(DoOneCrawlMessage) calls Thread.sleep() with a lock held 365 Normal

dk.netarkivet.harvester.harvesting.OnNSDomainsDecideRule

Violation Line Priority
Dm: Method dk.netarkivet.harvester.harvesting.OnNSDomainsDecideRule.convertToDomain(String) invokes toString() method on a String 147 Normal
SnVI: dk.netarkivet.harvester.harvesting.OnNSDomainsDecideRule is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.ContentSizeAnnotationPostProcessor

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.ContentSizeAnnotationPostProcessor is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.MySQLSpecifics

Violation Line Priority
SQL: A prepared statement is generated from a nonconstant String at dk.netarkivet.harvester.datamodel.MySQLSpecifics.dropJobConfigsTmpTable(Connection, String) 89 Low

dk.netarkivet.harvester.tools.HarvestTemplateApplication

Violation Line Priority
XFB: Method dk.netarkivet.harvester.tools.HarvestTemplateApplication.download(String) directly allocates a specific implementation of xml interfaces 139 Low

dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport$FIELD

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 59 Low
SBSC: Method dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport$FIELD.genHeaderLine(String) concatenates strings using + in a loop 98 Normal
REC: Exception is caught when Exception is not thrown in dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport$FIELD.genLine(FrontierReportLine, String) 86 Low

dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport

Violation Line Priority
FE: Test for floating point equality in dk.netarkivet.harvester.harvesting.frontier.FrontierReportCsvExport.getDisplayValue(double) 130 Low

dk.netarkivet.harvester.webinterface.HarvestStatusRunningTablesSort

Violation Line Priority
DLS: Dead store to order in dk.netarkivet.harvester.webinterface.HarvestStatusRunningTablesSort.getSortOrderByHarvestName(String) 108 Low
DLS: Dead store to columnId in dk.netarkivet.harvester.webinterface.HarvestStatusRunningTablesSort.sortByHarvestName(String, int) 148 Low

dk.netarkivet.harvester.webinterface.SnapshotHarvestDefinition

Violation Line Priority
CI: Class dk.netarkivet.harvester.webinterface.SnapshotHarvestDefinition is final but declares protected field dk.netarkivet.harvester.webinterface.SnapshotHarvestDefinition.log -1 Low

dk.netarkivet.common.utils.FilebasedFreeSpaceProvider

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.utils.FilebasedFreeSpaceProvider.getBytesFree(File) 94 Low

dk.netarkivet.common.utils.ReadOnlyByteArray

Violation Line Priority
EI2: dk.netarkivet.common.utils.ReadOnlyByteArray.ReadOnlyByteArray(byte[]) may expose internal representation by storing an externally mutable object into ReadOnlyByteArray.array 39 Normal

dk.netarkivet.common.distribute.AbstractRemoteFile

Violation Line Priority
REC: Exception is caught when Exception is not thrown in dk.netarkivet.common.distribute.AbstractRemoteFile.copyTo(File) 155 Low

dk.netarkivet.common.distribute.FTPRemoteFile

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.FTPRemoteFile is Serializable; consider declaring a serialVersionUID -1 Normal
SBSC: Method dk.netarkivet.common.distribute.FTPRemoteFile.FTPRemoteFile(File, boolean, boolean, boolean, RemoteFileSettings) concatenates strings using + in a loop 237 Normal
CI: Class dk.netarkivet.common.distribute.FTPRemoteFile is final but declares protected field dk.netarkivet.common.distribute.FTPRemoteFile.checksum -1 Low
MS: dk.netarkivet.common.distribute.FTPRemoteFile.FTP_RETRIES isn't final but should be 65 High
MS: dk.netarkivet.common.distribute.FTPRemoteFile.FTP_DATATIMEOUT isn't final but should be 70 High

dk.netarkivet.common.distribute.ExtendedFTPRemoteFile

Violation Line Priority
Se: The field dk.netarkivet.common.distribute.ExtendedFTPRemoteFile.FTP_RETRIES is transient but isn't set by deserialization -1 Low
Se: The field dk.netarkivet.common.distribute.ExtendedFTPRemoteFile.FTP_DATATIMEOUT is transient but isn't set by deserialization -1 Low
SnVI: dk.netarkivet.common.distribute.ExtendedFTPRemoteFile is Serializable; consider declaring a serialVersionUID -1 Normal
SBSC: Method dk.netarkivet.common.distribute.ExtendedFTPRemoteFile.ExtendedFTPRemoteFile(ArchiveRecord) concatenates strings using + in a loop 362 Normal

dk.netarkivet.common.distribute.HTTPRemoteFile

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.HTTPRemoteFile is Serializable; consider declaring a serialVersionUID -1 Low
MS: dk.netarkivet.common.distribute.HTTPRemoteFile.HTTPREMOTEFILE_PORT_NUMBER isn't final but should be 83 High
Nm: Confusing to have methods dk.netarkivet.common.distribute.HTTPRemoteFile.getChecksum() and dk.netarkivet.archive.bitarchive.distribute.RemoveAndGetFileMessage.getCheckSum() 262 Low

dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$HTTPRemoteFileRegistryHandler

Violation Line Priority
Dm: dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$HTTPRemoteFileRegistryHandler.handle(String, HttpServletRequest, HttpServletResponse, int) is or uses a map or set of URLs, which can be a performance hog 279 High

dk.netarkivet.common.distribute.HTTPRemoteFileRegistry

Violation Line Priority
ST: Write to static field dk.netarkivet.common.distribute.HTTPRemoteFileRegistry.instance from instance method dk.netarkivet.common.distribute.HTTPRemoteFileRegistry.cleanup() 232 Normal
DE: dk.netarkivet.common.distribute.HTTPRemoteFileRegistry.cleanup() might ignore java.lang.Exception 229 Low
Dm: dk.netarkivet.common.distribute.HTTPRemoteFileRegistry.registeredFiles is or uses a map or set of URLs, which can be a performance hog -1 High
MS: dk.netarkivet.common.distribute.HTTPRemoteFileRegistry.instance should be package protected -1 Normal

dk.netarkivet.common.distribute.HTTPSRemoteFile

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.HTTPSRemoteFile is Serializable; consider declaring a serialVersionUID -1 Low
MS: dk.netarkivet.common.distribute.HTTPSRemoteFile.HTTPSREMOTEFILE_KEYSTORE_FILE isn't final but should be 73 High
MS: dk.netarkivet.common.distribute.HTTPSRemoteFile.HTTPSREMOTEFILE_KEYSTORE_PASSWORD isn't final but should be 76 High
MS: dk.netarkivet.common.distribute.HTTPSRemoteFile.HTTPSREMOTEFILE_KEY_PASSWORD isn't final but should be 79 High

dk.netarkivet.common.distribute.FileRemoteFile

Violation Line Priority
SnVI: dk.netarkivet.common.distribute.FileRemoteFile is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.common.distribute.FileRemoteFile defines non-transient non-serializable instance field log -1 Normal

dk.netarkivet.common.distribute.JMSConnectionSunMQ

Violation Line Priority
ST: Write to static field dk.netarkivet.common.distribute.JMSConnectionSunMQ.instance from instance method dk.netarkivet.common.distribute.JMSConnectionSunMQ.cleanup() 184 High
MS: dk.netarkivet.common.distribute.JMSConnectionSunMQ.RECONNECT_ERRORCODES should be package protected 75 Normal
MS: dk.netarkivet.common.distribute.JMSConnectionSunMQ.JMS_BROKER_HOST isn't final but should be 95 High
MS: dk.netarkivet.common.distribute.JMSConnectionSunMQ.JMS_BROKER_PORT isn't final but should be 101 High

dk.netarkivet.common.tools.ExtractCDX

Violation Line Priority
ITA: Method dk.netarkivet.common.tools.ExtractCDX.main(String[]) uses Collection.toArray() with zero-length array argument 65 Low

dk.netarkivet.common.tools.ReformatTranslationFile

Violation Line Priority
RV: dk.netarkivet.common.tools.ReformatTranslationFile.main(String[]) ignores return value of java.io.File.createNewFile() 78 Low

dk.netarkivet.common.webinterface.GUIWebServer

Violation Line Priority
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 162 Low

dk.netarkivet.archive.indexserver.distribute.IndexRequestMessage

Violation Line Priority
SnVI: dk.netarkivet.archive.indexserver.distribute.IndexRequestMessage is Serializable; consider declaring a serialVersionUID -1 Normal

dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.maxConcurrentJobs from instance method dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.TestIndexRequestServer() 141 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.listeningInterval from instance method dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.TestIndexRequestServer() 145 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.currentJobs from instance method dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.TestIndexRequestServer() 160 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.conn from instance method dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.TestIndexRequestServer() 163 Low
Dm: dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.TestIndexRequestServer() invokes System.exit(...), which shuts down the entire virtual machine 157 Normal
MS: dk.netarkivet.archive.indexserver.distribute.TestIndexRequestServer.JOBS_FOR_TESTINDEX isn't final but should be 100 High

dk.netarkivet.archive.indexserver.distribute.IndexRequestServer

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.maxConcurrentJobs from instance method dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.IndexRequestServer() 112 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.listeningInterval from instance method dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.IndexRequestServer() 116 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.currentJobs from instance method dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.IndexRequestServer() 121 Low
ST: Write to static field dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.conn from instance method dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.IndexRequestServer() 124 Low
DLS: Dead store to theFoundIDs in dk.netarkivet.archive.indexserver.distribute.IndexRequestServer.doGenerateIndex(IndexRequestMessage) 348 Normal

dk.netarkivet.archive.arcrepository.distribute.JMSArcRepositoryClient

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepository.distribute.JMSArcRepositoryClient.instance from instance method dk.netarkivet.archive.arcrepository.distribute.JMSArcRepositoryClient.close() 168 Normal

dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation.instance from instance method dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation.cleanup() 1044 Normal
REC: Exception is caught when Exception is not thrown in dk.netarkivet.archive.arcrepository.bitpreservation.FileBasedActiveBitPreservation.uploadMissingFiles(Replica, String[]) 769 Low

dk.netarkivet.archive.arcrepository.bitpreservation.DatabasePreservationState

Violation Line Priority
SBSC: Method dk.netarkivet.archive.arcrepository.bitpreservation.DatabasePreservationState.toString() concatenates strings using + in a loop 312 Normal

dk.netarkivet.archive.arcrepository.bitpreservation.DatabaseBasedActiveBitPreservation

Violation Line Priority
ST: Write to static field dk.netarkivet.archive.arcrepository.bitpreservation.DatabaseBasedActiveBitPreservation.instance from instance method dk.netarkivet.archive.arcrepository.bitpreservation.DatabaseBasedActiveBitPreservation.cleanup() 760 High

dk.netarkivet.harvester.harvesting.distribute.DomainStats

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.distribute.DomainStats is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.report.AbstractHarvestReport

Violation Line Priority
DLS: Dead store to ANNOTATION_PART_INDEX in dk.netarkivet.harvester.harvesting.report.AbstractHarvestReport.processHarvestLine(String, boolean) 343 Low
DLS: Dead store to MAX_PARTS in dk.netarkivet.harvester.harvesting.report.AbstractHarvestReport.processHarvestLine(String, boolean) 342 Low
DLS: Dead store to MIN_CRAWL_LOG_PARTS in dk.netarkivet.harvester.harvesting.report.AbstractHarvestReport.processHarvestLine(String, boolean) 341 Low

dk.netarkivet.harvester.harvesting.report.LegacyHarvestReport

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.report.LegacyHarvestReport is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.report.BnfHarvestReport

Violation Line Priority
SnVI: dk.netarkivet.harvester.harvesting.report.BnfHarvestReport is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.harvesting.extractor.ExtractorOAI

Violation Line Priority
RCN: Redundant nullcheck of cs, which is known to be non-null in dk.netarkivet.harvester.harvesting.extractor.ExtractorOAI.extract(CrawlURI) 142 Low
Dm: Use of non-localized String.toUpperCase() or String.toLowerCase 111 Low
SnVI: dk.netarkivet.harvester.harvesting.extractor.ExtractorOAI is Serializable; consider declaring a serialVersionUID -1 Low
Se: Class dk.netarkivet.harvester.harvesting.extractor.ExtractorOAI defines non-transient non-serializable instance field log -1 Normal

dk.netarkivet.harvester.harvesting.controller.JMXHeritrixController

Violation Line Priority
UPM: Private method dk.netarkivet.harvester.harvesting.controller.JMXHeritrixController.getHeritrixAttribute(String) is never called 516 Low

dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController

Violation Line Priority
RCN: Redundant nullcheck of connection which is known to be null in dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController.getMBeanServerConnection() 936 Low
NP: Load of known null value in dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController.getMBeanServerConnection() 936 Low
Bx: Method dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController.fetchCrawlServiceJobAttributes(CrawlProgressMessage) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead 447 Low
Bx: Method dk.netarkivet.harvester.harvesting.controller.BnfHeritrixController.fetchCrawlServiceJobAttributes(CrawlProgressMessage) invokes inefficient Double(double) constructor; use Double.valueOf(double) instead 471 Low

dk.netarkivet.harvester.harvesting.controller.BnfHeritrixLauncher

Violation Line Priority
UW: Unconditional wait in dk.netarkivet.harvester.harvesting.controller.BnfHeritrixLauncher.doCrawl() 187 Low

dk.netarkivet.harvester.harvesting.controller.DefaultHeritrixLauncher

Violation Line Priority
UW: Unconditional wait in dk.netarkivet.harvester.harvesting.controller.DefaultHeritrixLauncher.doCrawlLoop() 238 Low
ICAST: Result of integer multiplication cast to long in dk.netarkivet.harvester.harvesting.controller.DefaultHeritrixLauncher.doCrawlLoop() 238 Low

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypes

Violation Line Priority
CI: Class dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypes is final but declares protected field dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypes.tableNames -1 Low
MS: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypes.tableNames should be both final and package protected 50 Low

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldType

Violation Line Priority
SnVI: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldType is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.batch.FileRemover

Violation Line Priority
SnVI: dk.netarkivet.common.utils.batch.FileRemover is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.cdx.GetCDXRecordsBatchJob

Violation Line Priority
SnVI: dk.netarkivet.common.utils.cdx.GetCDXRecordsBatchJob is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.common.utils.cdx.BinSearch$PrefixIterable$1

Violation Line Priority
FI: dk.netarkivet.common.utils.cdx.BinSearch$PrefixIterable$1.finalize() is public; should be protected 214 Normal

dk.netarkivet.common.utils.cdx.ARCFilenameCDXRecordFilter

Violation Line Priority
SnVI: dk.netarkivet.common.utils.cdx.ARCFilenameCDXRecordFilter is Serializable; consider declaring a serialVersionUID -1 Low

dk.netarkivet.harvester.datamodel.Password

Violation Line Priority
UwF: Password.id not initialized in constructor -1 Low
Nm: Confusing to have methods dk.netarkivet.harvester.datamodel.Password.getUsername() and dk.netarkivet.common.distribute.RemoteFileSettings.getUserName() 113 Low

dk.netarkivet.monitor.jmx.HostForwarding$NoHostInvocationHandler

Violation Line Priority
UwF: HostForwarding$NoHostInvocationHandler.singleMBeanObject not initialized in constructor -1 Low

dk.netarkivet.viewerproxy.DelegatingController

Violation Line Priority
UwF: DelegatingController.availableSet not initialized in constructor -1 Low

dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$FileInfo

Violation Line Priority
SIC: Should dk.netarkivet.common.distribute.HTTPRemoteFileRegistry$FileInfo be a _static_ inner class? -1 Normal

dk.netarkivet.common.distribute.arcrepository.LocalArcRepositoryClient$1

Violation Line Priority
SIC: The class dk.netarkivet.common.distribute.arcrepository.LocalArcRepositoryClient$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.common.distribute.indexserver.TrivialJobIndexCache

Violation Line Priority
UrF: Unread field: dk.netarkivet.common.distribute.indexserver.TrivialJobIndexCache.log 47 Normal

dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$1

Violation Line Priority
SIC: The class dk.netarkivet.harvester.datamodel.HarvestDefinitionDBDAO$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$ReportIterator

Violation Line Priority
SIC: Should dk.netarkivet.harvester.harvesting.frontier.FullFrontierReport$ReportIterator be a _static_ inner class? -1 Normal

dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp$1

Violation Line Priority
SIC: The class dk.netarkivet.viewerproxy.reporting.CrawlLogLinesMatchingRegexp$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob$1

Violation Line Priority
SIC: The class dk.netarkivet.viewerproxy.reporting.HarvestedUrlsForDomainBatchJob$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.wayback.NetarchiveResourceStore$1

Violation Line Priority
SIC: The class dk.netarkivet.wayback.NetarchiveResourceStore$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.wayback.aggregator.AggregationWorker$2

Violation Line Priority
SIC: The class dk.netarkivet.wayback.aggregator.AggregationWorker$2 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$1

Violation Line Priority
SIC: The class dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$1 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$2

Violation Line Priority
SIC: The class dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$2 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$3

Violation Line Priority
SIC: The class dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUURIFactory$3 could be refactored into a named _static_ inner class -1 Low

dk.netarkivet.deploy.ScriptConstants

Violation Line Priority
HSC: dk.netarkivet.deploy.ScriptConstants.JMXREMOTE_PASSWORD_HEADER is initialized to a string constant 2228 characters long that is duplicated in 2 other class files -1 Normal
HSC: dk.netarkivet.deploy.ScriptConstants.JMXREMOTE_ACCESS_HEADER is initialized to a string constant 2320 characters long that is duplicated in 2 other class files -1 Normal

dk.netarkivet.common.CommonSettings

Violation Line Priority
MS: dk.netarkivet.common.CommonSettings.SETTINGS isn't final but should be 53 High
MS: dk.netarkivet.common.CommonSettings.ENVIRONMENT_NAME isn't final but should be 60 High
MS: dk.netarkivet.common.CommonSettings.DIR_COMMONTEMPDIR isn't final but should be 67 High
MS: dk.netarkivet.common.CommonSettings.REMOTE_FILE_CLASS isn't final but should be 74 High
MS: dk.netarkivet.common.CommonSettings.JMS_BROKER_CLASS isn't final but should be 81 High
MS: dk.netarkivet.common.CommonSettings.JMS_BROKER_RETRIES isn't final but should be 88 High
MS: dk.netarkivet.common.CommonSettings.HTTP_PORT_NUMBER isn't final but should be 94 High
MS: dk.netarkivet.common.CommonSettings.ARC_REPOSITORY_CLIENT isn't final but should be 103 High
MS: dk.netarkivet.common.CommonSettings.MAX_NUM_BATCH_EXCEPTIONS isn't final but should be 110 High
MS: dk.netarkivet.common.CommonSettings.BATCH_LOGGING_INTERVAL isn't final but should be 117 High
MS: dk.netarkivet.common.CommonSettings.BATCH_DEFAULT_TIMEOUT isn't final but should be 125 High
MS: dk.netarkivet.common.CommonSettings.MONITOR_REGISTRY_CLIENT isn't final but should be 132 High
MS: dk.netarkivet.common.CommonSettings.MONITOR_REGISTRY_CLIENT_REREGISTERDELAY isn't final but should be 140 High
MS: dk.netarkivet.common.CommonSettings.INDEXSERVER_CLIENT isn't final but should be 150 High
MS: dk.netarkivet.common.CommonSettings.UNIX_SORT_USE_COMMON_TEMP_DIR isn't final but should be 162 High
MS: dk.netarkivet.common.CommonSettings.CACHE_DIR isn't final but should be 171 High
MS: dk.netarkivet.common.CommonSettings.PROCESS_TIMEOUT isn't final but should be 179 High
MS: dk.netarkivet.common.CommonSettings.NOTIFICATIONS_CLASS isn't final but should be 186 High
MS: dk.netarkivet.common.CommonSettings.MAIL_SERVER isn't final but should be 192 High
MS: dk.netarkivet.common.CommonSettings.JMX_PORT isn't final but should be 197 High
MS: dk.netarkivet.common.CommonSettings.JMX_RMI_PORT isn't final but should be 202 High
MS: dk.netarkivet.common.CommonSettings.JMX_PASSWORD_FILE isn't final but should be 210 High
MS: dk.netarkivet.common.CommonSettings.JMX_ACCESS_FILE isn't final but should be 219 High
MS: dk.netarkivet.common.CommonSettings.JMX_TIMEOUT isn't final but should be 226 High
MS: dk.netarkivet.common.CommonSettings.WEBINTERFACE_SETTINGS isn't final but should be 232 High
MS: dk.netarkivet.common.CommonSettings.WEBINTERFACE_LANGUAGE isn't final but should be 239 High
MS: dk.netarkivet.common.CommonSettings.WEBINTERFACE_LANGUAGE_LOCALE isn't final but should be 244 High
MS: dk.netarkivet.common.CommonSettings.WEBINTERFACE_LANGUAGE_NAME isn't final but should be 250 High
MS: dk.netarkivet.common.CommonSettings.SITESECTION_CLASS isn't final but should be 257 High
MS: dk.netarkivet.common.CommonSettings.SITESECTION_WEBAPPLICATION isn't final but should be 265 High
MS: dk.netarkivet.common.CommonSettings.HARVEST_STATUS_DFT_PAGE_SIZE isn't final but should be 273 High
MS: dk.netarkivet.common.CommonSettings.TLDS isn't final but should be 279 High
MS: dk.netarkivet.common.CommonSettings.DB_SPECIFICS_CLASS isn't final but should be 287 High
MS: dk.netarkivet.common.CommonSettings.DB_IS_DERBY_IF_CONTAINS isn't final but should be 294 High
MS: dk.netarkivet.common.CommonSettings.DB_BASE_URL isn't final but should be 301 High
MS: dk.netarkivet.common.CommonSettings.DB_MACHINE isn't final but should be 308 High
MS: dk.netarkivet.common.CommonSettings.DB_PORT isn't final but should be 315 High
MS: dk.netarkivet.common.CommonSettings.DB_DIR isn't final but should be 322 High
MS: dk.netarkivet.common.CommonSettings.DB_CONN_VALID_CHECK_TIMEOUT isn't final but should be 335 Low
MS: dk.netarkivet.common.CommonSettings.DB_POOL_MIN_SIZE isn't final but should be 343 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_MAX_SIZE isn't final but should be 351 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_ACQ_INC isn't final but should be 359 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_MAX_STM isn't final but should be 371 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_MAX_STM_PER_CONN isn't final but should be 383 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_IDLE_CONN_TEST_PERIOD isn't final but should be 392 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_IDLE_CONN_TEST_ON_CHECKIN isn't final but should be 401 High
MS: dk.netarkivet.common.CommonSettings.DB_POOL_IDLE_CONN_TEST_QUERY isn't final but should be 410 High
MS: dk.netarkivet.common.CommonSettings.DB_USERNAME isn't final but should be 416 High
MS: dk.netarkivet.common.CommonSettings.DB_PASSWORD isn't final but should be 421 High
MS: dk.netarkivet.common.CommonSettings.BITARCHIVE_LIMIT_FOR_RECORD_DATATRANSFER_IN_FILE isn't final but should be 428 High
MS: dk.netarkivet.common.CommonSettings.REPLICAS_SETTINGS isn't final but should be 436 High
MS: dk.netarkivet.common.CommonSettings.REPLICA_TAG isn't final but should be 444 High
MS: dk.netarkivet.common.CommonSettings.REPLICAID_TAG isn't final but should be 451 High
MS: dk.netarkivet.common.CommonSettings.REPLICANAME_TAG isn't final but should be 459 High
MS: dk.netarkivet.common.CommonSettings.REPLICATYPE_TAG isn't final but should be 467 High
MS: dk.netarkivet.common.CommonSettings.REPLICA_IDS isn't final but should be 474 High
MS: dk.netarkivet.common.CommonSettings.USE_REPLICA_ID isn't final but should be 480 High
MS: dk.netarkivet.common.CommonSettings.THIS_PHYSICAL_LOCATION isn't final but should be 487 High
MS: dk.netarkivet.common.CommonSettings.APPLICATION_NAME isn't final but should be 494 High
MS: dk.netarkivet.common.CommonSettings.APPLICATION_INSTANCE_ID isn't final but should be 504 High
MS: dk.netarkivet.common.CommonSettings.FREESPACE_PROVIDER_CLASS isn't final but should be 512 High
MS: dk.netarkivet.common.CommonSettings.BATCHJOBS_CLASS isn't final but should be 522 High
MS: dk.netarkivet.common.CommonSettings.BATCHJOBS_JARFILE isn't final but should be 533 High
MS: dk.netarkivet.common.CommonSettings.BATCHJOBS_BASEDIR isn't final but should be 541 High
MS: dk.netarkivet.common.CommonSettings.FTP_SERVER_NAME isn't final but should be 545 High
MS: dk.netarkivet.common.CommonSettings.FTP_SERVER_PORT isn't final but should be 550 High
MS: dk.netarkivet.common.CommonSettings.FTP_USER_NAME isn't final but should be 555 High
MS: dk.netarkivet.common.CommonSettings.FTP_USER_PASSWORD isn't final but should be 560 High
MS: dk.netarkivet.common.CommonSettings.FTP_RETRIES_SETTINGS isn't final but should be 566 High
MS: dk.netarkivet.common.CommonSettings.FTP_DATATIMEOUT_SETTINGS isn't final but should be 572 High

dk.netarkivet.archive.ArchiveSettings

Violation Line Priority
MS: dk.netarkivet.archive.ArchiveSettings.DIRS_ARCREPOSITORY_ADMIN isn't final but should be 60 High
MS: dk.netarkivet.archive.ArchiveSettings.ARCREPOSITORY_UPLOAD_RETRIES isn't final but should be 68 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_MIN_SPACE_LEFT isn't final but should be 79 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_MIN_SPACE_REQUIRED isn't final but should be 89 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_SERVER_FILEDIR isn't final but should be 101 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_HEARTBEAT_FREQUENCY isn't final but should be 109 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_ACCEPTABLE_HEARTBEAT_DELAY isn't final but should be 119 High
MS: dk.netarkivet.archive.ArchiveSettings.BITARCHIVE_BATCH_JOB_TIMEOUT isn't final but should be 128 High
MS: dk.netarkivet.archive.ArchiveSettings.ENVIRONMENT_THIS_CREDENTIALS isn't final but should be 136 High
MS: dk.netarkivet.archive.ArchiveSettings.DIR_ARCREPOSITORY_BITPRESERVATION isn't final but should be 144 High
MS: dk.netarkivet.archive.ArchiveSettings.ADMIN_CLASS isn't final but should be 151 High
MS: dk.netarkivet.archive.ArchiveSettings.BASEURL_ARCREPOSITORY_ADMIN_DATABASE isn't final but should be 164 High
MS: dk.netarkivet.archive.ArchiveSettings.MACHINE_ARCREPOSITORY_ADMIN_DATABASE isn't final but should be 175 High
MS: dk.netarkivet.archive.ArchiveSettings.PORT_ARCREPOSITORY_ADMIN_DATABASE isn't final but should be 186 High
MS: dk.netarkivet.archive.ArchiveSettings.DIR_ARCREPOSITORY_ADMIN_DATABASE isn't final but should be 197 High
MS: dk.netarkivet.archive.ArchiveSettings.CLASS_ARCREPOSITORY_ADMIN_DATABASE isn't final but should be 205 High
MS: dk.netarkivet.archive.ArchiveSettings.RECONNECT_MAX_TRIES_ADMIN_DATABASE isn't final but should be 213 High
MS: dk.netarkivet.archive.ArchiveSettings.RECONNECT_DELAY_ADMIN_DATABASE isn't final but should be 221 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_CONN_VALID_CHECK_TIMEOUT isn't final but should be 235 Low
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_MIN_SIZE isn't final but should be 243 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_MAX_SIZE isn't final but should be 251 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_ACQ_INC isn't final but should be 259 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_MAX_STM isn't final but should be 272 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_MAX_STM_PER_CONN isn't final but should be 285 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_IDLE_CONN_TEST_PERIOD isn't final but should be 295 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_IDLE_CONN_TEST_ON_CHECKIN isn't final but should be 305 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_POOL_IDLE_CONN_TEST_QUERY isn't final but should be 315 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_USERNAME isn't final but should be 322 High
MS: dk.netarkivet.archive.ArchiveSettings.DB_PASSWORD isn't final but should be 328 High
MS: dk.netarkivet.archive.ArchiveSettings.CLASS_ARCREPOSITORY_BITPRESERVATION isn't final but should be 336 High
MS: dk.netarkivet.archive.ArchiveSettings.CHECKSUM_BASEDIR isn't final but should be 343 High
MS: dk.netarkivet.archive.ArchiveSettings.CHECKSUM_MIN_SPACE_LEFT isn't final but should be 351 High
MS: dk.netarkivet.archive.ArchiveSettings.SINGLE_CHECKSUM_TIMEOUT isn't final but should be 360 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_REQUESTDIR isn't final but should be 367 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_MAXCLIENTS isn't final but should be 375 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_MAXTHREADS isn't final but should be 383 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_CHECKINTERVAL isn't final but should be 391 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_TIMEOUT isn't final but should be 399 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_LISTENING_INTERVAL isn't final but should be 406 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_SATISFACTORYTHRESHOLD_PERCENTAGE isn't final but should be 413 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXREQUEST_SERVER_CLASS isn't final but should be 422 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXING_OPTIMIZE_PARTIALINDEX isn't final but should be 428 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXING_OPTIMIZE_INDEX isn't final but should be 433 High
MS: dk.netarkivet.archive.ArchiveSettings.INDEXSERVER_INDEXING_LOOKFORDATAINOTHERBITARCHIVEREPLICAS isn't final but should be 442 High

dk.netarkivet.common.utils.EMailNotifications

Violation Line Priority
MS: dk.netarkivet.common.utils.EMailNotifications.MAIL_RECEIVER_SETTING isn't final but should be 57 High
MS: dk.netarkivet.common.utils.EMailNotifications.MAIL_SENDER_SETTING isn't final but should be 64 High

dk.netarkivet.harvester.HarvesterSettings

Violation Line Priority
MS: dk.netarkivet.harvester.HarvesterSettings.DEFAULT_SEEDLIST isn't final but should be 62 High
MS: dk.netarkivet.harvester.HarvesterSettings.VALID_SEED_REGEX isn't final but should be 71 High
MS: dk.netarkivet.harvester.HarvesterSettings.DOMAIN_DEFAULT_CONFIG isn't final but should be 79 High
MS: dk.netarkivet.harvester.HarvesterSettings.DOMAIN_DEFAULT_ORDERXML isn't final but should be 88 High
MS: dk.netarkivet.harvester.HarvesterSettings.DOMAIN_CONFIG_MAXRATE isn't final but should be 95 High
MS: dk.netarkivet.harvester.HarvesterSettings.DOMAIN_CONFIG_MAXBYTES isn't final but should be 102 High
MS: dk.netarkivet.harvester.HarvesterSettings.DOMAIN_CONFIG_MAXOBJECTS isn't final but should be 109 High
MS: dk.netarkivet.harvester.HarvesterSettings.ERRORFACTOR_PERMITTED_PREVRESULT isn't final but should be 119 High
MS: dk.netarkivet.harvester.HarvesterSettings.ERRORFACTOR_PERMITTED_BESTGUESS isn't final but should be 129 Low
MS: dk.netarkivet.harvester.HarvesterSettings.EXPECTED_AVERAGE_BYTES_PER_OBJECT isn't final but should be 138 High
MS: dk.netarkivet.harvester.HarvesterSettings.MAX_DOMAIN_SIZE isn't final but should be 145 High
MS: dk.netarkivet.harvester.HarvesterSettings.JOBS_MAX_RELATIVE_SIZE_DIFFERENCE isn't final but should be 154 High
MS: dk.netarkivet.harvester.HarvesterSettings.JOBS_MIN_ABSOLUTE_SIZE_DIFFERENCE isn't final but should be 163 High
MS: dk.netarkivet.harvester.HarvesterSettings.JOBS_MAX_TOTAL_JOBSIZE isn't final but should be 171 High
MS: dk.netarkivet.harvester.HarvesterSettings.JOBS_MAX_TIME_TO_COMPLETE isn't final but should be 179 High
MS: dk.netarkivet.harvester.HarvesterSettings.MAX_CONFIGS_PER_JOB_CREATION isn't final but should be 188 High
MS: dk.netarkivet.harvester.HarvesterSettings.SPLIT_BY_OBJECTLIMIT isn't final but should be 198 High
MS: dk.netarkivet.harvester.HarvesterSettings.USE_QUOTA_ENFORCER isn't final but should be 211 High
MS: dk.netarkivet.harvester.HarvesterSettings.JOB_TIMEOUT_TIME isn't final but should be 218 High
MS: dk.netarkivet.harvester.HarvesterSettings.GENERATE_JOBS_PERIOD isn't final but should be 227 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_CONTROLLER_SERVERDIR isn't final but should be 235 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_SERVERDIR_MINSPACE isn't final but should be 243 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_CONTROLLER_OLDJOBSDIR isn't final but should be 252 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_CONTROLLER_PRIORITY isn't final but should be 264 High
MS: dk.netarkivet.harvester.HarvesterSettings.INACTIVITY_TIMEOUT_IN_SECS isn't final but should be 273 High
MS: dk.netarkivet.harvester.HarvesterSettings.CRAWLER_TIMEOUT_NON_RESPONDING isn't final but should be 281 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_MONITOR_REFRESH_INTERVAL isn't final but should be 288 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_MONITOR_HISTORY_SAMPLE_RATE isn't final but should be 296 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_MONITOR_HISTORY_CHART_GEN_INTERVAL isn't final but should be 305 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_MONITOR_DISPLAYED_HISTORY_SIZE isn't final but should be 313 High
MS: dk.netarkivet.harvester.HarvesterSettings.CRAWL_LOOP_WAIT_TIME isn't final but should be 321 High
MS: dk.netarkivet.harvester.HarvesterSettings.SEND_READY_INTERVAL isn't final but should be 336 High
MS: dk.netarkivet.harvester.HarvesterSettings.SEND_READY_DELAY isn't final but should be 347 High
MS: dk.netarkivet.harvester.HarvesterSettings.FRONTIER_REPORT_WAIT_TIME isn't final but should be 355 High
MS: dk.netarkivet.harvester.HarvesterSettings.FRONTIER_REPORT_FILTER_CLASS isn't final but should be 363 High
MS: dk.netarkivet.harvester.HarvesterSettings.FRONTIER_REPORT_FILTER_ARGS isn't final but should be 371 High
MS: dk.netarkivet.harvester.HarvesterSettings.ABORT_IF_CONNECTION_LOST isn't final but should be 383 High
MS: dk.netarkivet.harvester.HarvesterSettings.WAIT_FOR_REPORT_GENERATION_TIMEOUT isn't final but should be 391 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_ADMIN_NAME isn't final but should be 398 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_ADMIN_PASSWORD isn't final but should be 405 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_GUI_PORT isn't final but should be 414 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_JMX_PORT isn't final but should be 425 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_JMX_USERNAME isn't final but should be 434 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_JMX_PASSWORD isn't final but should be 443 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_HEAP_SIZE isn't final but should be 452 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_JVM_OPTS isn't final but should be 460 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_CONTROLLER_CLASS isn't final but should be 467 High
MS: dk.netarkivet.harvester.HarvesterSettings.HERITRIX_LAUNCHER_CLASS isn't final but should be 474 High
MS: dk.netarkivet.harvester.HarvesterSettings.HARVEST_REPORT_CLASS isn't final but should be 481 High
MS: dk.netarkivet.harvester.HarvesterSettings.DISREGARD_SEEDURL_INFORMATION_IN_CRAWLLOG isn't final but should be 490 High
MS: dk.netarkivet.harvester.HarvesterSettings.DEDUPLICATION_ENABLED isn't final but should be 498 High
MS: dk.netarkivet.harvester.HarvesterSettings.METADATA_HERITRIX_FILE_PATTERN isn't final but should be 508 High
MS: dk.netarkivet.harvester.HarvesterSettings.METADATA_REPORT_FILE_PATTERN isn't final but should be 518 High
MS: dk.netarkivet.harvester.HarvesterSettings.METADATA_LOG_FILE_PATTERN isn't final but should be 528 High
MS: dk.netarkivet.harvester.HarvesterSettings.METADATA_GENERATE_ARCFILES_REPORT isn't final but should be 538 High
MS: dk.netarkivet.harvester.HarvesterSettings.ALIAS_TIMEOUT isn't final but should be 546 High
MS: dk.netarkivet.harvester.HarvesterSettings.RECOVERlOG_CONTINUATION_ENABLED isn't final but should be 554 High

dk.netarkivet.monitor.MonitorSettings

Violation Line Priority
MS: dk.netarkivet.monitor.MonitorSettings.JMX_USERNAME_SETTING isn't final but should be 60 High
MS: dk.netarkivet.monitor.MonitorSettings.JMX_PASSWORD_SETTING isn't final but should be 69 High
MS: dk.netarkivet.monitor.MonitorSettings.LOGGING_HISTORY_SIZE isn't final but should be 76 High
MS: dk.netarkivet.monitor.MonitorSettings.JMX_PROXY_TIMEOUT isn't final but should be 85 High
MS: dk.netarkivet.monitor.MonitorSettings.DEFAULT_REREGISTER_DELAY isn't final but should be 89 High
MS: dk.netarkivet.monitor.MonitorSettings.JMX_PREFERRED_MAX_LOG_LENGTH isn't final but should be 97 High
MS: dk.netarkivet.monitor.MonitorSettings.JMX_ABSOLUTE_MAX_LOG_LENGTH isn't final but should be 105 High

dk.netarkivet.viewerproxy.ViewerProxySettings

Violation Line Priority
MS: dk.netarkivet.viewerproxy.ViewerProxySettings.VIEWERPROXY_DIR isn't final but should be 57 High
MS: dk.netarkivet.viewerproxy.ViewerProxySettings.TRY_LOOKUP_URI_AS_FTP isn't final but should be 65 High
MS: dk.netarkivet.viewerproxy.ViewerProxySettings.MAXIMUM_OBJECT_IN_BROWSER isn't final but should be 73 High

dk.netarkivet.deploy.Constants

Violation Line Priority
MS: dk.netarkivet.deploy.Constants.BASEFILEDIR_SUBDIRECTORIES should be package protected 267 Normal

dk.netarkivet.wayback.WaybackSettings

Violation Line Priority
MS: dk.netarkivet.wayback.WaybackSettings.URL_CANONICALIZER_CLASSNAME isn't final but should be 54 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_ACQUIRE_INCREMENT isn't final but should be 66 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_IDLE_PERIOD isn't final but should be 68 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_MAX_SIZE isn't final but should be 70 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_MAX_STATEMENTS isn't final but should be 72 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_MIN_SIZE isn't final but should be 74 High
MS: dk.netarkivet.wayback.WaybackSettings.C3P0_TIMEOUT isn't final but should be 76 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_DB_URL isn't final but should be 82 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_DB_DRIVER isn't final but should be 84 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_REFLECTION_OPTIMIZER isn't final but should be 86 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_TRANSACTION_FACTORY isn't final but should be 88 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_DIALECT isn't final but should be 90 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_SHOW_SQL isn't final but should be 92 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_FORMAT_SQL isn't final but should be 94 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_HBM2DDL_AUTO isn't final but should be 96 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_USERNAME isn't final but should be 98 High
MS: dk.netarkivet.wayback.WaybackSettings.HIBERNATE_PASSWORD isn't final but should be 100 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_REPLICA isn't final but should be 106 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEX_TEMPDIR isn't final but should be 112 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_BATCH_OUTPUTDIR isn't final but should be 120 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEXER_MAXFAILEDATTEMPTS isn't final but should be 127 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEXER_PRODUCER_DELAY isn't final but should be 133 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEXER_PRODUCER_INTERVAL isn't final but should be 140 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEXER_CONSUMER_THREADS isn't final but should be 146 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_INDEXER_INITIAL_FILES isn't final but should be 153 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_AGGREGATOR_OUTPUT_DIR isn't final but should be 159 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_AGGREGATOR_TEMP_DIR isn't final but should be 163 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_AGGREGATOR_AGGREGATION_INTERVAL isn't final but should be 167 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_AGGREGATOR_MAX_INTERMEDIATE_INDEX_FILE_SIZE isn't final but should be 175 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_AGGREGATOR_MAX_MAIN_INDEX_FILE_SIZE isn't final but should be 183 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_RESOURCESTORE_CACHE_MAXFILES isn't final but should be 189 High
MS: dk.netarkivet.wayback.WaybackSettings.WAYBACK_RESOURCESTORE_CACHE_DIR isn't final but should be 193 High

dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUrlOperations

Violation Line Priority
MS: dk.netarkivet.wayback.batch.copycode.NetarchiveSuiteUrlOperations.ALL_SCHEMES should be package protected 59 Normal

dk.netarkivet.common.management.MBeanConnectorCreator

Violation Line Priority
MS: dk.netarkivet.common.management.MBeanConnectorCreator.isExposed should be package protected 64 Normal

dk.netarkivet.archive.checksum.distribute.ChecksumClient

Violation Line Priority
MS: dk.netarkivet.archive.checksum.distribute.ChecksumClient.log isn't final but should be 56 High

dk.netarkivet.harvester.datamodel.JobStatus

Violation Line Priority
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_NEW_KEY isn't final but should be 84 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_SUBMITTED_KEY isn't final but should be 86 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_STARTED_KEY isn't final but should be 88 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_DONE_KEY isn't final but should be 90 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_FAILED_KEY isn't final but should be 92 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_RESUBMITTED_KEY isn't final but should be 94 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_UNKNOWN_KEY isn't final but should be 96 High
MS: dk.netarkivet.harvester.datamodel.JobStatus.JOBSTATUS_FAILED_REJECTED_KEY isn't final but should be 98 High

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDAO

Violation Line Priority
MS: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldDAO.instance should be package protected -1 Normal

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldValueDAO

Violation Line Priority
MS: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldValueDAO.instance should be package protected -1 Normal

dk.netarkivet.harvester.scheduler.HarvestJobGenerator

Violation Line Priority
MS: dk.netarkivet.harvester.scheduler.HarvestJobGenerator.harvestDefinitionsBeingScheduled isn't final but should be 57 High

dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypeDAO

Violation Line Priority
MS: dk.netarkivet.harvester.datamodel.extendedfield.ExtendedFieldTypeDAO.instance should be package protected -1 Normal

dk.netarkivet.common.utils.cdx.CDXRecord

Violation Line Priority
Nm: Confusing to have methods dk.netarkivet.common.utils.cdx.CDXRecord.getArcfile() and dk.netarkivet.archive.bitarchive.distribute.GetMessage.getArcFile() 190 Low
Nm: Confusing to have methods dk.netarkivet.common.utils.cdx.CDXRecord.getMimetype() and dk.netarkivet.harvester.harvesting.distribute.MetadataEntry.getMimeType() 174 Low

dk.netarkivet.harvester.datamodel.DomainConfiguration

Violation Line Priority
Nm: Confusing to have methods dk.netarkivet.harvester.datamodel.DomainConfiguration.getID() and java.lang.Thread.getId() 534 Low
Nm: Confusing to have methods dk.netarkivet.harvester.datamodel.DomainConfiguration.getCrawlertraps() and dk.netarkivet.harvester.datamodel.Domain.getCrawlerTraps() 573 Low

dk.netarkivet.common.distribute.arcrepository.BatchStatus

Violation Line Priority
Nm: Confusing to have methods dk.netarkivet.common.distribute.arcrepository.BatchStatus.getBitArchiveAppId() and dk.netarkivet.archive.bitarchive.distribute.BitarchiveServer.getBitarchiveAppId() 121 Low

dk.netarkivet.common.distribute.arcrepository.Replica

Violation Line Priority
Nm: Confusing to have methods dk.netarkivet.common.distribute.arcrepository.Replica.getId() and dk.netarkivet.common.distribute.NetarkivetMessage.getID() 262 Low

dk.netarkivet.harvester.webinterface.HarvestStatusQuery

Violation Line Priority
Nm: Confusing to have methods dk.netarkivet.harvester.webinterface.HarvestStatusQuery.getHarvestId() and dk.netarkivet.harvester.harvesting.HeritrixFiles.getHarvestID() 341 Low